Swf library load fix#48
Closed
barisyild wants to merge 2 commits into
Closed
Conversation
The Flash/AIR SWFLibrary was missing rootPath support that the other library types (AnimateLibrary, SWFLiteLibrary) already had. This caused non-embedded SWF files to fail loading because the path resolution used the wrong base directory. - Add rootPath field and __fromManifest override to SWFLibrary, matching the pattern used by AnimateLibrary and SWFLiteLibrary - Fix rootPath in manifest to empty string since SWF files are placed at the output root, not under lib/ - Preserve the -swf-lib fallback for backwards compatibility Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The else block (applicationDomain = currentDomain) was reached in the non-embed case because paths.exists(id) is false when the SWF is not in the manifest's asset list. This caused the file to never be loaded. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.