fix(RHOAIENG-85746): print Feature summary and Model evaluation in Fi… - #9445
fix(RHOAIENG-85746): print Feature summary and Model evaluation in Fi…#9445jkyaw wants to merge 3 commits into
Conversation
…refox Disable PatternFly's CSS-grid table layout for those tabs so Firefox print-to-PDF can render the rows instead of a blank page. Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (9)
📝 WalkthroughWalkthroughPrint styles force PatternFly tables to use native table display modes. Feature summary and model evaluation tables disable responsive grid layouts. Print mode hides the feature search toolbar while retaining feature data. Tests verify printed content and confirm that grid classes are absent. Merge Risk: ⚪ Minimal · up to This localized change fixes missing Feature summary and Model evaluation tables in Firefox print-to-PDF and includes related tests; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![odh-dashboard-agent[bot]](https://avatars.githubusercontent.com/in/3714079?s=60&v=4){kind=small}
There was a problem hiding this comment.
Preflight Agent Report
Verdict:
Commit: b294715
Checks
| Check | Status | Details |
|---|---|---|
| Conflicts | Mergeable, but branch is behind main — rebase before merge |
|
| Application Quality Gate (automl) | ⏭️ | PASS — lint, type-check, unit tests for changed package |
| Unit Tests | ⏭️ | PASS |
| Lint (main) | Still running | |
| Type Check (main) | Still running | |
| Contract Tests | Still running | |
| Cypress Tests | Still running | |
| Builds | Still running (Konflux, Sidecar, Docker) | |
| Jira | ✅ | RHOAIENG-85746 |
| Test Coverage | ✅ | 3 test files updated — print mode, native layout, portal content |
| PR Body | ✅ | Jira URL, description, testing steps, before/after screenshots |
| Human Reviews | REVIEW_REQUIRED — no approvals yet | |
| Style | ✅ | No violations — gridBreakPoint="" (PF prop, priority 1) and !important inside @media print both justified |
| RBAC | ➖ | N/A — frontend-only styling change |
| Jira Eval | ➖ | No acceptance criteria in issue (bug report with screenshots only) |
| Claude Review | 🧹 1 nit | See nits below |
🧹 Nitpick comments (1)
packages/automl/frontend/src/app/components/run-results/AutomlModelDetailsModal/AutomlModelDetailsModal.scss (1)
510: 🧹 Nit · Claude review
The .odh-autox-print-hide-element CSS class is defined here but no longer referenced anywhere in the codebase — className="odh-autox-print-hide-element" was removed from SearchInput in this PR (replaced with the cleaner !print conditional render). The rule is now dead code and can be removed.
Automated by ODH Dashboard Agent
The search toolbar is already omitted in print via a !print render guard, so .odh-autox-print-hide-element was unused. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9445 +/- ##
==========================================
+ Coverage 59.97% 59.98% +0.01%
==========================================
Files 3128 3128
Lines 97606 97606
Branches 25707 25707
==========================================
+ Hits 58538 58553 +15
+ Misses 39068 39053 -15
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
1 participant
https://issues.redhat.com/browse/RHOAIENG-85746
Description
Firefox print-to-PDF from AutoML Model details → Download left Feature summary and Model evaluation blank (section title only). PatternFly tables default to a CSS-grid layout (pf-m-grid-md) that Firefox cannot print.
This matches confusion matrix: gridBreakPoint="" for a native table layout, plus print CSS that forces display: table. Feature search is omitted in the print document.
How Has This Been Tested?
Lint, type-check, and unit tests passed in packages/automl/frontend.
Test Impact
Updated Jest tests for Feature summary, Model evaluation, and the model details print portal to assert table content and that pf-m-grid-md is not applied.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
mainSummary by CodeRabbit
Bug Fixes
Tests