Skip to content

tests(RHOAIENG-60178): Remove duplicated tests - #9331

Open
Philip-Carneiro wants to merge 2 commits into
opendatahub-io:mainfrom
Philip-Carneiro:fix/remove-duplicate-mr-settings-tests
Open

tests(RHOAIENG-60178): Remove duplicated tests#9331
Philip-Carneiro wants to merge 2 commits into
opendatahub-io:mainfrom
Philip-Carneiro:fix/remove-duplicate-mr-settings-tests

Conversation

@Philip-Carneiro

@Philip-Carneiro Philip-Carneiro commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

https://redhat.atlassian.net/browse/RHOAIENG-60178

Description

Remove duplicated tests between upstream and midstream.
It was found only one file of cypress tests with duplicated tests, In this file it was removed 4 tests.

Duplicate Tests Removed

# Removed Midstream Test (it block) Upstream Equivalent (it block) What it tests
1 'Shows empty state when there are no registries' (was at L340) 'should show empty state when no registries exist' (L132) Both assert findEmptyState().should('exist') with empty registry list
2 'Shows table when there are registries' inside describe('ModelRegistriesTable') (was at L1075) 'should show table when there are registries' (L138) Both assert findTable().should('exist') and findModelRegistryRow('test-registry-1').should('exist')
3 'disables confirm button before name is typed' inside describe('DeleteModelRegistryModal') (was at L1503) 'disables confirm button before name is typed' (L192) Both assert delete confirm button is disabled before typing registry name
4 'enables confirm button after name is typed' inside describe('DeleteModelRegistryModal') (was at L1503) 'enables confirm button after name is typed' (L196) Both type registry name then assert findSubmitButton().should('be.enabled')

How Has This Been Tested?

nothing was changed, only remove duplicated tests

Test Impact

nothing was changed, only remove duplicated tests

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • The code follows our Best Practices (React coding standards, PatternFly usage, performance considerations)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign claudialphonse78 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Philip-Carneiro, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 195054f7-3c03-49fb-8fb6-90473915c135

📥 Commits

Reviewing files that changed from the base of the PR and between 08280b2 and 29ce46c.

📒 Files selected for processing (1)
  • packages/cypress/cypress/tests/mocked/modelRegistrySettings/modelRegistrySettings.cy.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@odh-dashboard-agent odh-dashboard-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preflight Agent Report

Verdict: ⚠️ READY WITH WARNINGS
Commit: 5a5fdd8

Checks
Check Status Details
Conflicts Mergeable, no conflicts
CI ⚠️ 4 passed · 4 skipped (path filter, expected for test-only change) · 10 pending (infra/build) · 0 failed
CodeRabbit Skipped (--skip-review coderabbit)
Human review ⚠️ REVIEW_REQUIRED — no approvals yet
Claude review No issues found — clean removal of 4 documented duplicate tests
Style review Not applicable (no CSS/style changes)
RBAC review Not applicable (test file only)
Jira Eval RHOAIENG-60178 has no formal acceptance criteria
Jira RHOAIENG-60178 — Task, In Progress
Test Coverage All changed files are test files (.cy.ts) — deduplication PR
PR Body ⚠️ All sections filled and Jira URL present; self-checklist items unchecked (minor — acceptable for a test-deletion PR)

Automated by ODH Dashboard Agent

@rhods-ci-bot

Copy link
Copy Markdown

/early-gate-build

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.04%. Comparing base (736c9b9) to head (29ce46c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9331      +/-   ##
==========================================
- Coverage   60.08%   60.04%   -0.04%     
==========================================
  Files        3128     3128              
  Lines       97606    97640      +34     
  Branches    25707    25850     +143     
==========================================
- Hits        58644    58627      -17     
- Misses      38962    39013      +51     
Flag Coverage Δ
cypress-mock 69.52% <ø> (-0.08%) ⬇️
unit 30.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 12 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08280b2...29ce46c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sridarna

Copy link
Copy Markdown
Contributor

@Philip-Carneiro Are you looking for review?

@sridarna

Copy link
Copy Markdown
Contributor

@ConorOM1 @manaswinidas Could you review this PR? please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants