Skip to content

chore(deps): upgrade backend to Fastify 5 on v2.25.0-fixes - #9244

Closed
PR3MM wants to merge 1 commit into
opendatahub-io:v2.25.0-fixesfrom
PR3MM:v2.25.0-fixes
Closed

chore(deps): upgrade backend to Fastify 5 on v2.25.0-fixes#9244
PR3MM wants to merge 1 commit into
opendatahub-io:v2.25.0-fixesfrom
PR3MM:v2.25.0-fixes

Conversation

@PR3MM

@PR3MM PR3MM commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

https://issues.redhat.com/browse/RHOAIENG-81841

Description

Ports the Fastify 5 backend migration from main (#9202) onto the v2.25.0-fixes release branch. Bumps fastify and all version-coupled @fastify/* plugins in the same change set.

Dependency changes (backend/package.json):

Package Before After
fastify 4.16.0 5.11.x
fastify-plugin 4.5.1 5.1.0
@fastify/autoload 5.7.1 6.5.0
@fastify/http-proxy 9.5.0 11.6.0
@fastify/reply-from (transitive 9.x) 12.6.4 (transitive)
@fastify/static 6.10.2 10.1.3
@fastify/websocket 8.2.0 11.3.0
@fastify/sensible 5.2.0 6.0.4
@fastify/accepts 4.3.0 5.0.4
undici 5.x (transitive) 7.29.0 (transitive)
typescript ^5.3.3 ~5.4.5
Backend code changes for Fastify 5 API compatibility:
  • server.ts: loggerloggerInstance
  • routes/wss/k8s/index.ts: WebSocket handler uses connection directly; typed ping/pong/error callbacks
  • routes/api/storage/index.ts + utils/resourceUtils.ts: log.error uses pino object form
  • tsconfig.json: skipLibCheck: true (Fastify 5 typings on TS 5.4)
  • backend/package-lock.json: regenerated for Fastify 5 dependency tree

How Has This Been Tested?

Automated

  • npm run test (backend) — lint, type-check, jest 17/17 pass
  • npm run build (backend) — pass
  • npm ci --dry-run (backend) — pass
    Resolved lock versions:
  • fastify@5.11.3
  • @fastify/websocket@11.3.0
  • @fastify/http-proxy@11.6.0
  • @fastify/autoload@6.5.0
  • @fastify/reply-from@12.6.4
  • undici@7.29.0
  • typescript@5.4.5

Manual

Logged in as htpasswd-cluster-admin-user via make login + npm run dev.

Area Test Result
Boot /api/health, /api/status, /api/config 200
DSC / DSCI /api/dsc/status, /api/dsci/status 200 (real component data)
K8s REST /api/k8s/... proxy 200
UI Dashboard loads Pass
WebSocket /wss/k8s/... watch in browser (confirm 101 before merge)

Test Impact

  • No new unit tests — this branch has no websocket proxy spec
  • Functional coverage via manual testing above per RHOAIENG-81841
  • No Cypress changes — backend-only dependency migration

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • The code follows our Best Practices (React coding standards, PatternFly usage, performance considerations)
    If you have UI changes:
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.
    After the PR is posted & before it merges:
  • The developer has tested their solution on a cluster by using the image produced by the PR to v2.25.0-fixes

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)
  • main
  • master
  • incubation
  • rhoai

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: fe797a6c-282c-4a21-9999-8143c40d4f3f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mturley for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@manaswinidas manaswinidas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create this PR to stable-2.x

@PR3MM

PR3MM commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Created PR to stable-2.x

@PR3MM PR3MM closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants