Skip to content

Cherrypick/tfa fixes - #8670

Merged
openshift-merge-bot[bot] merged 8 commits into
opendatahub-io:stable-2.xfrom
sridarna:cherrypick/TFA-fixes
Jul 21, 2026
Merged

Cherrypick/tfa fixes#8670
openshift-merge-bot[bot] merged 8 commits into
opendatahub-io:stable-2.xfrom
sridarna:cherrypick/TFA-fixes

Conversation

@sridarna

@sridarna sridarna commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes E2E tests in 2.25 TFA which are failing with Test Maintain.

How Has This Been Tested?

job/components/job/dashboard/job/dashboard-e2e-tests/1904/

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • The code follows our Best Practices (React coding standards, PatternFly usage, performance considerations)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci

openshift-ci Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress This PR is in WIP state label Jul 19, 2026
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 36319823-09aa-476f-ad2f-7ba1956d1d18

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

sridarna and others added 2 commits July 19, 2026 16:45
…hub-io#5143)

* update OCI_SECRET_DETAILS_FILE to  OCI_SECRET_VALUE field

* Add changes to OCI deploy test

* Update auth key to dummy value in test-variables example file

* Unquarntine OCI test

* update checkInferenceServiceState

* Update upload secret file functionality

* update the updateSecretDetailsFile function

* Add the single-serving-button to oci test

---------

Co-authored-by: Fede Alonso <fealonso@redhat.com>
@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.79%. Comparing base (0a61717) to head (15241cb).
⚠️ Report is 1 commits behind head on stable-2.x.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-2.x    #8670      +/-   ##
==============================================
- Coverage       67.95%   67.79%   -0.17%     
==============================================
  Files            2238     2238              
  Lines           50822    50822              
  Branches        14243    14243              
==============================================
- Hits            34538    34455      -83     
- Misses          16284    16367      +83     

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a61717...15241cb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sridarna
sridarna marked this pull request as ready for review July 20, 2026 02:12
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jul 20, 2026
@openshift-ci
openshift-ci Bot requested review from antowaddle and manosnoam July 20, 2026 02:12
@sridarna sridarna changed the title Cherrypick/tfa fixes [wip] Cherrypick/tfa fixes Jul 20, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress This PR is in WIP state label Jul 20, 2026
@sridarna sridarna changed the title [wip] Cherrypick/tfa fixes Cherrypick/tfa fixes Jul 20, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jul 20, 2026
@sridarna
sridarna requested review from ConorOM1 and crackcodecamp and removed request for manosnoam July 20, 2026 13:53

@crackcodecamp crackcodecamp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci Bot removed the lgtm label Jul 20, 2026

@antowaddle antowaddle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antowaddle, crackcodecamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 96bfc44 into opendatahub-io:stable-2.x Jul 21, 2026
75 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants