Upgrade Node.js base image from ubi9/nodejs-20 to ubi9/nodejs-22 - #7670
Conversation
ubi9/nodejs-20 has been deprecated by Red Hat, causing deprecated-base-image-check failures in Konflux builds. Migrate all Dockerfiles, CI workflows, and engine constraints to ubi9/nodejs-22. Ref: https://redhat.atlassian.net/browse/RHOAIENG-64644 Signed-off-by: Akshay Ghodake <aghodake@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable-2.x #7670 +/- ##
==============================================
+ Coverage 67.91% 67.96% +0.04%
==============================================
Files 2238 2238
Lines 50822 50822
Branches 14243 14243
==============================================
+ Hits 34516 34539 +23
+ Misses 16306 16283 -23 see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
lucferbux
left a comment
There was a problem hiding this comment.
/lgtm
/approve
based on the slack conversation, due to missing gaps in our e2e test we are gonna approve to trigger odh builds, if anything is wrong let's rollback
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0a61717
into
opendatahub-io:stable-2.x
ubi9/nodejs-20 has been deprecated by Red Hat, causing deprecated-base-image-check failures in Konflux conforma builds for odh-dashboard and odh-mod-arch-model-registry components. Upstream PR: opendatahub-io#7670 Ref: https://redhat.atlassian.net/browse/RHOAIENG-64644 Signed-off-by: Akshay Ghodake <aghodake@redhat.com>
Summary
ubi9/nodejs-20has been deprecated, causingdeprecated-base-image-checkfailures in Konflux/conforma builds forodh-dashboardandodh-mod-arch-model-registrycomponents.Changes
Dockerfile,packages/gen-ai/Dockerfile.openshift,packages/gen-ai/Dockerfile.workspace,packages/model-registry/Dockerfile.workspace,packages/plugin-template/Dockerfile.workspace,scripts/ci/Dockerfiletest.yml,modular-arch-quality-gates.yml,gen-ai-frontend-build.ymlbackend/,frontend/,packages/model-registry/upstream/frontend/docs/workspace-dockerfiles.mdJira
https://redhat.atlassian.net/browse/RHOAIENG-64644
Test plan
npm ci— passed with Node 22npm run build— webpack compiled successfully