Skip to content

Upgrade Node.js base image from ubi9/nodejs-20 to ubi9/nodejs-22 - #7670

Merged
openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:stable-2.xfrom
crackcodecamp:fix/upgrade-nodejs-20-to-22
May 29, 2026
Merged

Upgrade Node.js base image from ubi9/nodejs-20 to ubi9/nodejs-22#7670
openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:stable-2.xfrom
crackcodecamp:fix/upgrade-nodejs-20-to-22

Conversation

@crackcodecamp

@crackcodecamp crackcodecamp commented May 26, 2026

Copy link
Copy Markdown
Member

Summary

  • ubi9/nodejs-20 has been deprecated, causing deprecated-base-image-check failures in Konflux/conforma builds for odh-dashboard and odh-mod-arch-model-registry components.
  • Migrates all Dockerfiles, CI workflows, engine constraints, and docs from Node.js 20 to Node.js 22.

Changes

  • Dockerfiles: Dockerfile, packages/gen-ai/Dockerfile.openshift, packages/gen-ai/Dockerfile.workspace, packages/model-registry/Dockerfile.workspace, packages/plugin-template/Dockerfile.workspace, scripts/ci/Dockerfile
  • CI Workflows: test.yml, modular-arch-quality-gates.yml, gen-ai-frontend-build.yml
  • package.json engines: root, backend/, frontend/, packages/model-registry/upstream/frontend/
  • package-lock.json: Updated project engine entries (third-party deps unchanged)
  • Docs: docs/workspace-dockerfiles.md

Jira

https://redhat.atlassian.net/browse/RHOAIENG-64644

Test plan

  • npm ci — passed with Node 22
  • npm run build — webpack compiled successfully
  • Unit tests — 251 suites, 2177 tests all passed
  • CI pipeline validation after merge

ubi9/nodejs-20 has been deprecated by Red Hat, causing
deprecated-base-image-check failures in Konflux builds.
Migrate all Dockerfiles, CI workflows, and engine constraints
to ubi9/nodejs-22.

Ref: https://redhat.atlassian.net/browse/RHOAIENG-64644

Signed-off-by: Akshay Ghodake <aghodake@redhat.com>
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2768a50b-c5db-432f-a2a9-492d3fbbbe33

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bobbravo2

Copy link
Copy Markdown
Member

/retest

@dpanshug dpanshug left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
The code changes looks good to me, without any breaking changes. Testing on cluster will require to merge this

@manaswinidas

Copy link
Copy Markdown
Member

/retest

1 similar comment
@dpanshug

Copy link
Copy Markdown
Contributor

/retest

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.96%. Comparing base (00447fc) to head (8d4ea5a).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           stable-2.x    #7670      +/-   ##
==============================================
+ Coverage       67.91%   67.96%   +0.04%     
==============================================
  Files            2238     2238              
  Lines           50822    50822              
  Branches        14243    14243              
==============================================
+ Hits            34516    34539      +23     
+ Misses          16306    16283      -23     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00447fc...8d4ea5a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucferbux lucferbux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

based on the slack conversation, due to missing gaps in our e2e test we are gonna approve to trigger odh builds, if anything is wrong let's rollback

@openshift-ci

openshift-ci Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 0a61717 into opendatahub-io:stable-2.x May 29, 2026
46 of 48 checks passed
yash2189 pushed a commit to red-hat-data-services/odh-dashboard that referenced this pull request May 29, 2026
ubi9/nodejs-20 has been deprecated by Red Hat, causing
deprecated-base-image-check failures in Konflux conforma builds
for odh-dashboard and odh-mod-arch-model-registry components.

Upstream PR: opendatahub-io#7670
Ref: https://redhat.atlassian.net/browse/RHOAIENG-64644

Signed-off-by: Akshay Ghodake <aghodake@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants