Remove group errors and allow freeform group names (#5034)

[nananosirova]

(cherry picked from commit ee8a9d1)

https://redhat.atlassian.net/browse/RHOAIENG-59753

Reproduced issue without this fix, doesn't occur after the fix:

How Has This Been Tested?

All manual tests below have been verified on a cluster:

Test 1: Error no longer appears with missing groups

1. Create a group and configure it in the dashboard:

   oc adm groups new phantom-group

2. Go to Settings → User management, add phantom-group to admin or user groups, save.
3. Delete the group:

   oc delete group phantom-group

4. Reload the User management page.
5. Expected: No error popup, no inline warning alert. The page loads normally with helper text: "Select from existing groups, or specify a new group name." The phantom-group still appears in the list (still configured in Auth CR) and can be deselected/removed.

✅ Verified

Test 2: Freeform group creation works

1. Go to Settings → User management.
2. Click the admin groups or user groups dropdown.
3. Type a group name that doesn't exist (e.g., my-new-team).
4. Expected: A "Define new group:" option appears at the top of the dropdown. Selecting it adds the group to the list. (No OpenShift Group object is created — it's stored as a reference in the Auth CR only.)
5. Save the settings, reload the page.
6. Expected: The custom group persists in the selection.

✅ Verified

Test 3: Existing groups still work

1. Ensure at least one real OpenShift Group exists:

   oc adm groups new real-group

2. Go to Settings → User management, select real-group from the dropdown, save.
3. Expected: Group is selected and persists after reload. No errors.

✅ Verified

Test 4: At least one group is still required

1. Go to Settings → User management.
2. Deselect all admin groups (or all user groups).
3. Expected: The Save button is disabled with message "One or more group must be selected."

✅ Verified

Test Impact

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
• The code follows our Best Practices (React coding standards, PatternFly usage, performance considerations)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ecd611e6-a734-4acb-9848-f55ae8c512a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.91%. Comparing base (0438a9a) to head (ded2536).

Additional details and impacted files

@@              Coverage Diff               @@
##           stable-2.x    #7558      +/-   ##
==============================================
- Coverage       67.93%   67.91%   -0.03%     
==============================================
  Files            2238     2238              
  Lines           50851    50822      -29     
  Branches        14255    14243      -12     
==============================================
- Hits            34545    34515      -30     
- Misses          16306    16307       +1     

Files with missing lines	Coverage Δ
frontend/src/concepts/userConfigs/groupTypes.ts	100.00% <ø> (ø)
...ontend/src/concepts/userConfigs/useWatchGroups.tsx	95.12% <ø> (-0.63%)	⬇️
frontend/src/concepts/userConfigs/utils.ts	100.00% <100.00%> (+21.62%)	⬆️
frontend/src/pages/groupSettings/GroupSettings.tsx	96.77% <100.00%> (+10.66%)	⬆️

... and 14 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0438a9a...ded2536. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaoDaoNoCode]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [DaoDaoNoCode]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment