Skip to content

add default cache-control headers for module web files - #6986

Merged
openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:stable-2.xfrom
christianvogt:backport-cache-fix
Apr 1, 2026
Merged

add default cache-control headers for module web files#6986
openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:stable-2.xfrom
christianvogt:backport-cache-fix

Conversation

@christianvogt

@christianvogt christianvogt commented Mar 31, 2026

Copy link
Copy Markdown
Member

fixes https://redhat.atlassian.net/browse/RHOAIENG-52182

Back port of #6632 for cache-control headers.
Back port a small change from #5080 for moduleFederation.js

This backport is to prevent cache related issues which occur after an upgrade.

Tested against 2.25.3 cluster with image build from local changes.

  • Confirmed presence of cache-control: no-cache header on requests made to /_mf/.
  • Confirmed modules, such as model-registry, load correctly.

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bdc99a8e-49bb-4ca0-9df6-73daaf4fb73a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rsun19 rsun19 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rsun19

rsun19 commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

@christianvogt did you have a 2.25 cluster to test it

@christianvogt

Copy link
Copy Markdown
Member Author

Created a custom image and replace dashboard image on test cluster. Sent you test cluster details.

@rsun19

rsun19 commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

tested, looks good

@openshift-ci

openshift-ci Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 84a98b3 into opendatahub-io:stable-2.x Apr 1, 2026
276 of 288 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants