Remove typing aliases deprecated in python 3.9. Also replace usages of typing.Union/Optional with |#5277
Merged
Merged
Conversation
DylanRussell
changed the title
herin049
approved these changes
Jun 8, 2026
…son/generator.py Co-authored-by: Lukas Hering <40302054+herin049@users.noreply.github.com>
herin049
reviewed
Jun 8, 2026
emdneto
approved these changes
Jun 9, 2026
emdneto
left a comment
emdneto
left a comment
Member
There was a problem hiding this comment.
Not sure why ruff didn't catch this
DylanRussell
changed the title
Member
|
Ruff has the "UP" rule, fyi. |
Contributor
Author
|
https://docs.astral.sh/ruff/rules/#pyupgrade-up doesn't seem to include these typing deprecations yet. Not sure why it didn't catch Union/Optional replaced by | as it appears to have a UP rule for that.. Anyway I think this should be good to merge now |
Contributor
Author
|
I think the failing checks should be suppressed.. |
xrmx
approved these changes
Jun 17, 2026
github-project-automation
Bot
moved this from Easy to review / merge / close
to Approved PRs
in Python PR digest
xrmx
added
Approve Public API check
Merged
via the queue into
open-telemetry:main
with commit Jun 17, 2026
7283c4c
1034 of 1036 checks passed
github-project-automation
Bot
moved this from Ready for merge
to Done
in Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing typing aliases deprecated in python 3.9 -- see https://docs.python.org/3/library/typing.html#deprecated-aliases -- replacing them with the now supported
collections.abcequivalentReplace all usages of
typing.Unionandtyping.Optionalwith|.Type of change
How Has This Been Tested?
Unit tests
Does This PR Require a Contrib Repo Change?
Checklist: