refactor: rename exit_lidarparse_timestamp to exit_source_timestamp#909
Merged
Conversation
qianlongding
approved these changes
Jun 12, 2026
yunowo
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the
exit_lidarparse_timestampfield toexit_source_timestampin theLidarMetastructure to better reflect its generic nature as a source exit timestamp rather than being specific to the g3dlidarparse element.Changes include
LidarMetastruct definition ing3d_lidar_meta.hadd_lidar_meta()function signature and implementationexit_source_timestampg3dinference.mdgvametaconvert.cppChecklist: