🐛 fix: race condition in search query execution#2929
Open
kamilsi wants to merge 1 commit into
Open
Conversation
When a user opens the search modal and starts typing immediately, executeQuery() is triggered. Since buildIndex() is asynchronous, the fuse variable might still be undefined when .search() is called. Added safety checks for fuse initialization.
✅ Deploy Preview for snazzy-dango-efb2ec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user opens the search modal and starts typing immediately,
executeQuery()is triggered. SincebuildIndex()is asynchronous (fetchingindex.json), thefusevariable might still beundefinedwhen.search()is called, resulting inUncaught TypeError: Cannot read properties of undefined (reading 'search').Solution
executeQuery()to ensureindexedis true andfuseis initialized before proceeding.output.firstChildbefore attempting to set focus targets for keyboard navigation, preventing secondary errors when results are empty or still rendering.