Skip to content

refactor(runtime): drop the unread LaunchContext.data_dir and comment the supervisor rebind#271

Closed
mfw78 wants to merge 1 commit into
refactor/rename-runtime-addonfrom
refactor/launchcontext-touchups
Closed

refactor(runtime): drop the unread LaunchContext.data_dir and comment the supervisor rebind#271
mfw78 wants to merge 1 commit into
refactor/rename-runtime-addonfrom
refactor/launchcontext-touchups

Conversation

@mfw78

@mfw78 mfw78 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

From the #193 review.

What

  • Remove LaunchContext.data_dir. The launcher (AssembledRuntime::launch) never reads it; the local store gets the data directory via BuilderContext.data_dir at component-build time (host/component/builder.rs), so this copy was dead weight. Removed from the struct and all four constructions (the two builder launch paths, bootstrap::run, and a test).
  • Comment the let mut supervisor = supervisor rebind so the reason (the dispatch_* calls take &mut self) is not a mystery.

Why top-of-train

LaunchContext and its constructions are edited by several M0 cars (executor threading, WASI-clock override, launch-message wording), so removing the field mid-stack collides with those. Doing it once at the top removes the field from the final shape in a single commit.

Not included

The reviewer notes on the boot-comment direction and the "using ctrl-c" log were already fixed downstream by the drop-CLI-wording and signal-registration cars, so they need no change here.

Testing

cargo clippy -p nexum-runtime -p nexum-cli --all-targets --all-features -- -D warnings clean; builder tests pass.

AI Assistance

Claude Code (Opus 4.8) used for the change and PR body; the train rebasing was driven with jj.

@mfw78 mfw78 force-pushed the refactor/rename-runtime-addon branch from 3c14157 to bf974f9 Compare July 8, 2026 05:00
@mfw78 mfw78 force-pushed the refactor/launchcontext-touchups branch from a4395d8 to 054f90d Compare July 8, 2026 05:00
@mfw78 mfw78 force-pushed the refactor/rename-runtime-addon branch from bf974f9 to d0c8ff6 Compare July 8, 2026 05:31
@mfw78 mfw78 force-pushed the refactor/launchcontext-touchups branch from 054f90d to e37a2c3 Compare July 8, 2026 05:31
@mfw78 mfw78 force-pushed the refactor/rename-runtime-addon branch from d0c8ff6 to 327a7f4 Compare July 8, 2026 06:21
@mfw78 mfw78 force-pushed the refactor/launchcontext-touchups branch from e37a2c3 to b14414e Compare July 8, 2026 06:21
@mfw78

mfw78 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by the consolidated follow-up PR #278, which carries this change as a preserved commit. Closing to reduce the outstanding-PR count; the commit history is unchanged.

@mfw78 mfw78 closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant