refactor(runtime): drop the unread LaunchContext.data_dir and comment the supervisor rebind#271
Closed
mfw78 wants to merge 1 commit into
Closed
Conversation
3c14157 to
bf974f9
Compare
a4395d8 to
054f90d
Compare
bf974f9 to
d0c8ff6
Compare
054f90d to
e37a2c3
Compare
… the supervisor rebind
d0c8ff6 to
327a7f4
Compare
e37a2c3 to
b14414e
Compare
Contributor
Author
|
Superseded by the consolidated follow-up PR #278, which carries this change as a preserved commit. Closing to reduce the outstanding-PR count; the commit history is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the #193 review.
What
LaunchContext.data_dir. The launcher (AssembledRuntime::launch) never reads it; the local store gets the data directory viaBuilderContext.data_dirat component-build time (host/component/builder.rs), so this copy was dead weight. Removed from the struct and all four constructions (the two builder launch paths,bootstrap::run, and a test).let mut supervisor = supervisorrebind so the reason (thedispatch_*calls take&mut self) is not a mystery.Why top-of-train
LaunchContextand its constructions are edited by several M0 cars (executor threading, WASI-clock override, launch-message wording), so removing the field mid-stack collides with those. Doing it once at the top removes the field from the final shape in a single commit.Not included
The reviewer notes on the boot-comment direction and the "using ctrl-c" log were already fixed downstream by the drop-CLI-wording and signal-registration cars, so they need no change here.
Testing
cargo clippy -p nexum-runtime -p nexum-cli --all-targets --all-features -- -D warningsclean; builder tests pass.AI Assistance
Claude Code (Opus 4.8) used for the change and PR body; the train rebasing was driven with jj.