Add tray icon and close/minimize-to-tray options#2075
Closed
blockedby wants to merge 1 commit into
Closed
Conversation
|
Thanks for your interest in translating Nuclear! We use Crowdin to manage translations. Please contribute translations there instead: If you're new to Crowdin, check out the getting started guide for translators. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements desktop tray support and tray window behavior requested in discussion #2004.
tray-iconfeature and registers a Nuclear tray icon/menuWayland / Linux tray notes
Tauri v2's tray support is backed by the
tray-iconcrate on Linux. The Linux implementation uses libappindicator/libayatana-appindicator, so it targets StatusNotifierItem/AppIndicator-capable tray hosts rather than the legacy X11-only system tray path. This should work on Wayland compositors when the desktop/bar provides an SNI/AppIndicator tray host, such as KDE Plasma or Hyprland with a compatible tray applet/bar.Verification
Run locally on this branch:
pnpm --filter @nuclearplayer/player lint✅pnpm --filter @nuclearplayer/player type-check✅pnpm --filter @nuclearplayer/player build:frontend✅pnpm --filter @nuclearplayer/player test✅ — 61 files, 569 passed, 1 todocd packages/player/src-tauri && cargo check✅cd packages/player/src-tauri && cargo test✅ — 24 passedRust checks emitted existing MPD dead-code warnings unrelated to this change.
Manual Wayland verification still needed
I could not run a live GUI Wayland tray-host smoke test in this environment. Suggested manual checks:
Show Nuclearrestores/focuses the window andQuitexits the app.Close to trayin Preferences > General, close the main window, and confirm it hides instead of quitting.Minimize to tray, minimize the main window, and confirm it hides to tray and can be restored from the tray icon/menu.