fix(arborist): give shadowed workspaces a local bin shim on hoisting collision#9719
Closed
gopalsunkari860 wants to merge 2 commits into
Closed
fix(arborist): give shadowed workspaces a local bin shim on hoisting collision#9719gopalsunkari860 wants to merge 2 commits into
gopalsunkari860 wants to merge 2 commits into
Conversation
…on during parallel npm version runs
…collision When two workspaces depend on different packages that export the same bin name, both get hoisted to the root node_modules, but bin-links only creates one shim there (first one wins by sort order). The losing workspace had no local node_modules/.bin, so `npm exec -w` silently fell through to the root shim and ran the wrong package's script. Detect the collision during rebuild's bin-linking pass and give any workspace that directly depends on the shadowed package its own local shim, symlinking the real package folder into the workspace's node_modules and reusing bin-links' existing (unmodified) linking logic. Fixes: npm#9712 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.