Skip to content

remove execsync as dependency and use native child_process calls in… #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kvnvelasco wants to merge 2 commits into
base: 2.x.x
Choose a base branch
from
Open

remove execsync as dependency and use native child_process calls in… #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cec413
remove execsync as dependencies and use native child_process calls in…
kvnvelasco Aug 30, 2015
c37a08d
update engine versions to reflect execsync changes
kvnvelasco Aug 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ var path = require('path');
var yeoman = require('yeoman-generator');
var chalk = require('chalk');
var _s = require('underscore.string');
var sh = require('execSync');
var shared = require('../shared.js');
var run = require('child_process').exec;


var SPGenerator = yeoman.generators.Base.extend({
init: function () {
Expand All @@ -21,7 +22,8 @@ var SPGenerator = yeoman.generators.Base.extend({
// Install dependencies unless --skip-install is passed
//////////////////////////////
if (!this.options['skip-install']) {
sh.run('bundle install --path vendor');
run('bundle install --path vendor')

this.installDependencies({
callback: function () {
console.log('\u001b[2J\u001b[0;0H');
Expand All @@ -36,8 +38,7 @@ var SPGenerator = yeoman.generators.Base.extend({
// If the --git flag is passed, initialize git and add for initial commit
//////////////////////////////
if (this.options['git']) {
sh.run('git init');
sh.run('git add . && git commit -m "Style Prototype Generation"');
run('git init && git add . && git commit -m "Style Prototype Generation"');
}
});
},
Expand Down Expand Up @@ -218,4 +219,4 @@ var SPGenerator = yeoman.generators.Base.extend({

});

module.exports = SPGenerator;
module.exports = SPGenerator;
2 changes: 1 addition & 1 deletion app/templates/_package-dev.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
"browser-sync": "^1.3.2"
},
"engines": {
"node": ">=0.8.0"
"node": ">=0.12.0"
}
}
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
"dependencies": {
"chalk": "^0.4.0",
"dateformat": "^1.0.8-1.2.3",
"execSync": "~1.0.1-pre",
"fs-extra": "^0.8.1",
"gulp-util": "^2.2.20",
"inquirer": "^0.4.1",
Expand All @@ -44,7 +43,7 @@
"yeoman-generator": "^0.16.0"
},
"engines": {
"node": ">=0.8.0"
"node": ">=0.12.0"
},
"licenses": [
{
Expand Down