Apply scroll factor by input device#4221
Draft
coleleavitt wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trackball { scroll-factor ... }like mouse and touchpad scroll factors.Issues
scroll-factordoes not apply to trackball devices #2841scroll-factorsilently ignored whentapis enabled in touchpad config #4202Testing
cargo test -q scroll_factor_falls_back_to_axis_source_without_device_kindcargo test -q scroll_factor_uses_libinput_device_kind_before_axis_sourcecargo test -q -p niri-config parse_scroll_factor_combinedcargo check --message-format=shortcargo check