fix(store): harden lookup maps against prototype pollution#2447
Draft
arturovt wants to merge 1 commit into
Draft
fix(store): harden lookup maps against prototype pollution#2447arturovt wants to merge 1 commit into
arturovt wants to merge 1 commit into
Conversation
Objects used as string-keyed dictionaries were initialized with `{}`,
inheriting Object.prototype. A key matching an inherited property
(e.g. `constructor`, `hasOwnProperty`) would return a truthy prototype
value instead of undefined, causing silent mismatches in lookups.
- Replace `{}` with Object.create(null) in all plain map initializations:
state name/path maps in StateFactory, buildGraph, nameToState,
findFullParentPath, topologicalSort, the actions metadata map,
and the FilterMap seeds in ofAction operators
- Replace ɵhasOwnProperty helper with Object.hasOwn(), which is safe
on null-prototype objects and removes the indirection
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many --target=test --all --configuration... |
❌ Failed | 2m 29s | View ↗ |
nx run-many --target=lint --all --exclude=creat... |
✅ Succeeded | 9s | View ↗ |
nx lint-types store |
✅ Succeeded | <1s | View ↗ |
nx run-many --target=build --all |
✅ Succeeded | 1m 48s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-06-02 19:50:38 UTC
@ngxs/devtools-plugin
@ngxs/form-plugin
@ngxs/hmr-plugin
@ngxs/router-plugin
@ngxs/storage-plugin
@ngxs/store
@ngxs/websocket-plugin
commit: |
BundleMonFiles updated (2)
Unchanged files (4)
Total files change -201B -0.12% Groups updated (1)
Final result: ❌ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Files updated (1)
Unchanged files (8)
Total files change -8B -0.04% Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (1)
Total files change -20B -0.03% Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objects used as string-keyed dictionaries were initialized with
{}, inheriting Object.prototype. A key matching an inherited property (e.g.constructor,hasOwnProperty) would return a truthy prototype value instead of undefined, causing silent mismatches in lookups.{}with Object.create(null) in all plain map initializations: state name/path maps in StateFactory, buildGraph, nameToState, findFullParentPath, topologicalSort, the actions metadata map, and the FilterMap seeds in ofAction operators