Skip to content

[client] Fix engine lifecyrcle race#6443

Merged
pappz merged 10 commits into
mainfrom
fix/engine-stop-error-handling
Jun 22, 2026
Merged

[client] Fix engine lifecyrcle race#6443
pappz merged 10 commits into
mainfrom
fix/engine-stop-error-handling

[client] fix Start/Stop race by making the run loop own engine shutdown

98c71d7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 16, 2026 in 35s

Annotations

Check failure on line 450 in client/internal/engine.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 29 to the 20 allowed.

See more on https://sonarcloud.io/project/issues?id=netbirdio_netbird&issues=AZ7QU3bfm73CI4ZPYdgT&open=AZ7QU3bfm73CI4ZPYdgT&pullRequest=6443

Check warning on line 450 in client/internal/engine.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 130 lines of code, which is greater than the 100 authorized. Split it into smaller functions.

See more on https://sonarcloud.io/project/issues?id=netbirdio_netbird&issues=AZ7QU3bfm73CI4ZPYdgS&open=AZ7QU3bfm73CI4ZPYdgS&pullRequest=6443