Backport FileDownlink timeout removal to v3.6#5288
Open
nathancheek wants to merge 1 commit into
Open
Conversation
* Backport nasa#4555 to v3.6.x * Ignore returned buffers when in COOLDOWN mode, matching IDLE mode behavior * Spelling fix * Update Ref topology to match changes to FileDownlink::config() --------- Co-authored-by: M Starch <LeStarch@googlemail.com>
nathancheek
force-pushed
the
fix/v3.6.x-FileDownlink
branch
from
42845fd to
b38e9d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
This backports the #4555 bugfix to v3.6.x. It also updates
FileDownlinkto handle returned buffers duringCOOLDOWNthe same way they are handled duringIDLEmode, rather than asserting.Rationale
Downstream throttling should not cause
FileDownlinkto assert.Testing/Review Recommendations
I've tested these
FileDownlinkchanges on Linux and the component seems to be operating as expected. Unfortunately, this PR changes theFileDownlink::configure()function header, removing thetimeoutargument, which breaks CI builds. Question: Should we change the external test deployments so they build? Should we overrideFileDownlink::configure()so it has a backwards-compatible function header with a dummyU32argument wheretimeoutused to be?Future Work
I propose bringing forward the handling of returned buffers in
COOLDOWNmode to F Primev4, makingbufferReturn_handler()handle returns inCOOLDOWNmode the same way it handles returns inIDLEmode.AI Usage (see policy)
N/A