Skip to content

backend/enhancement: adding jwtSecret field in Zendesk Config#1392

Merged
prakharritik merged 1 commit into
mainfrom
backend/zendesk/jwttoken
Jul 2, 2026
Merged

backend/enhancement: adding jwtSecret field in Zendesk Config#1392
prakharritik merged 1 commit into
mainfrom
backend/zendesk/jwttoken

Conversation

@Kuldeepkumawat144

@Kuldeepkumawat144 Kuldeepkumawat144 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • [ X] Enhancement
  • Refactoring
  • Dependency updates

Description

Additional Changes

  • This PR modifies the database schema (database migration added)
  • This PR modifies dhall configs/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code and addressed linter errors ./dev/format-all-files.sh
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Summary by CodeRabbit

  • New Features
    • Added support for an optional Zendesk JWT secret configuration value, enabling setups that require JWT-based Zendesk authentication.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Kuldeepkumawat144, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6f79feac-ef2b-4672-8727-264161890d15

📥 Commits

Reviewing files that changed from the base of the PR and between 9d0f8d9 and edbb4d1.

📒 Files selected for processing (1)
  • lib/mobility-core/src/Kernel/External/Ticket/Zendesk/Config.hs

Walkthrough

Added an optional jwtSecret field of type Maybe Text to the ZendeskCfg record in the Zendesk configuration module. No other logic or fields were modified.

Changes

Zendesk Config Update

Layer / File(s) Summary
Add jwtSecret field
lib/mobility-core/src/Kernel/External/Ticket/Zendesk/Config.hs
Adds a new optional jwtSecret :: Maybe Text field to the ZendeskCfg record.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A tiny field hops into place,
jwtSecret joins the config space.
Maybe Text, so soft and light,
A rabbit's tweak, done just right! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: adding the jwtSecret field to Zendesk config.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch backend/zendesk/jwttoken

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lib/mobility-core/src/Kernel/External/Ticket/Zendesk/Config.hs`:
- Around line 24-25: The Config record’s jwtSecret is currently stored as plain
Maybe Text, which can be exposed by the derived Show/ToJSON/FromJSON instances.
Update the Zendesk Config type so jwtSecret uses the same encrypted-field
pattern as apiKey (for example an EncryptedField 'AsEncrypted Text or equivalent
secure wrapper), and then adjust any serialization/access code in Config to work
with the encrypted representation rather than plaintext.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fb6cd63c-f3de-4c66-be28-fecd89c47fba

📥 Commits

Reviewing files that changed from the base of the PR and between 576aa71 and 9d0f8d9.

📒 Files selected for processing (1)
  • lib/mobility-core/src/Kernel/External/Ticket/Zendesk/Config.hs

Comment thread lib/mobility-core/src/Kernel/External/Ticket/Zendesk/Config.hs Outdated
@Kuldeepkumawat144 Kuldeepkumawat144 force-pushed the backend/zendesk/jwttoken branch from 9d0f8d9 to edbb4d1 Compare July 2, 2026 13:19
@prakharritik prakharritik merged commit f5c5710 into main Jul 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants