feat: include driver/conductor person_id in currentOperation#117
Open
Jayanth-Parthsarathy wants to merge 13 commits into
Open
feat: include driver/conductor person_id in currentOperation#117Jayanth-Parthsarathy wants to merge 13 commits into
Jayanth-Parthsarathy wants to merge 13 commits into
Conversation
…er id * [feat]: unpacked cluster id and returning destination using the cluster id * fix: deduped stops to cluster mapping * fix: removing duplicates for station
Look up emp_id by token_no for each non-empty side and surface it alongside the existing token fields. null when token is missing or no matching employee row exists. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pranavs6
force-pushed
the
master-gims
branch
2 times, most recently
from
June 2, 2026 18:09
dbe91fa to
00df999
Compare
pranavs6
force-pushed
the
master-gims
branch
2 times, most recently
from
July 6, 2026 11:31
5ec6967 to
63978da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
driver_person_idandconductor_person_id(bothOption<i64>) toCurrentOperationResponseemp_idfromemployees_internalfor each non-empty token;nullwhen the token is missing/empty or no matching row exists""rather thanNULLin places) are treated the same as missingTest plan
POST /internal/fleet-operator/{gtfs_id}/currentOperationwithdriver_tokenreturnsdriver_person_id,conductor_person_id: nullconductor_tokenreturnsconductor_person_id,driver_person_id: nullvehicle_number: both person ids populated if waybill has both tokens, null otherwisenull, request still succeeds🤖 Generated with Claude Code