Skip to content

[internal] Switch resolutions to workspace overrides #22865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arminmeh merged 1 commit into from
Jun 18, 2026
Merged

[internal] Switch resolutions to workspace overrides #22865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop

@cherniavskii cherniavskii Jun 17, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this fixes the issue for v8.x of MUI X, perhaps a better solution would be to only throw error on pnpm 11 in https://npmx.dev/package-code/@mui/internal-code-infra/v/0.0.4-canary.66/src/utils/pnpm.mjs#L415-L420

@Janpot Janpot Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would mean we'd need to maintain a third codepath to also update resolutions if it exists, which isn't even a pnpm field. I think backporting would be the right solution in this case. I would have done this, but I didn't realize it would be breaking.

@cherniavskii cherniavskii Jun 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't necessarily need to bump pnpm on v8.x though, this PR seams to be enough

Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,6 @@
"yargs": "catalog:",
"zod": "^4.3.6"
},
"resolutions": {
"ast-types": "^0.14.2"
},
"packageManager": "pnpm@10.27.0",
"engines": {
"pnpm": "10.27.0",
Expand Down
3 changes: 3 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,6 @@ onlyBuiltDependencies:
- nx
- sharp
- unrs-resolver

overrides:
ast-types: ^0.14.2
Loading