Skip to content

[DataGrid] Define overflowAnchor style at the right element (@arminmeh)#22860

Merged
arminmeh merged 4 commits into
v8.xfrom
cherry-pick-22849-to-v8.x
Jun 18, 2026
Merged

[DataGrid] Define overflowAnchor style at the right element (@arminmeh)#22860
arminmeh merged 4 commits into
v8.xfrom
cherry-pick-22849-to-v8.x

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-pick of #22849

@github-actions github-actions Bot added cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. feature: Rendering layout Related to the data grid Rendering engine scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected. labels Jun 17, 2026
@github-actions github-actions Bot requested review from MBilalShafi and arminmeh June 17, 2026 12:43
Comment thread packages/x-data-grid/src/components/containers/GridRootStyles.ts Outdated
Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
Comment thread packages/x-data-grid/src/components/containers/GridRootStyles.ts Outdated
Comment thread packages/x-data-grid/src/components/containers/GridRootStyles.ts Outdated
Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
@mui-bot

mui-bot commented Jun 17, 2026

Copy link
Copy Markdown

Deploy preview: https://deploy-preview-22860--material-ui-x.netlify.app/

Bundle size report

ℹ️ Using snapshot from parent commit a2d91dd (fallback from merge base 16934ab).

Bundle Parsed size Gzip size
@mui/x-data-grid 🔺+30B(+0.01%) ▼-1B(0.00%)
@mui/x-data-grid-pro 🔺+30B(+0.01%) 🔺+5B(0.00%)
@mui/x-data-grid-premium 🔺+30B(0.00%) 🔺+5B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 726079e

@cherniavskii

Copy link
Copy Markdown
Member

Hopefully #22846 (comment) would solve the React 18 issues

@arminmeh

Copy link
Copy Markdown
Contributor

@mui/infra
I have let Claude investigate this.
This is the report:

Root cause: eslint v10

  The chain:

  1. The CircleCI install-deps command always runs with package-overrides: react@<version>
  (.circleci/config.yml:80-81). For the React-18 job that's react@^18.
  2. That invokes code-infra's set-version-overrides. Looking at its source
  (cmdSetVersionOverrides.mjs:106-112), for a non-stable version it writes the React pins into
  package.json's resolutions field and then runs pnpm dedupe.
  3. pnpm dedupe is a full, non-frozen re-resolution of the whole graph (unlike the normal jobs, which
  install from the frozen lockfile). During that re-resolve, every version range is re-evaluated to
  its highest match.
  4. @mui/internal-code-infra declares "eslint": "^9.0.0 || ^10.0.0" (I confirmed this in the
  installed package manifest). eslint 10.5.0 was published, so the re-resolve now picks 10.5.0 instead
  of the locked 9.39.2.
  5. But code-infra's bundled lint plugins only support eslint ≤9 — eslint-plugin-import@2.32.0,
  eslint-plugin-jsx-a11y@6.10.2, eslint-plugin-react@7.37.5 (exactly the versions in your error).
  eslint 10 makes the graph unsatisfiable, and pnpm dedupe exits 1.

  - Stable jobs are fine: set-version-overrides with react@stable returns empty overrides and skips
  pnpm dedupe entirely (cmdSetVersionOverrides.mjs:33-35, 97-100), so they install frozen → eslint
  stays 9.39.2.
  - Only the override jobs (react@^18, use-material-ui-v6, use-material-ui-next) run the dedupe → only
  they float eslint to 10.

  Fix

  The real bug is upstream: code-infra's eslint: "^9.0.0 || ^10.0.0" range is wrong while its plugins
  cap at eslint 9. That should be reported/fixed in mui-public (@mui/internal-code-infra) — either cap
  eslint to ^9 or bump the plugins to eslint-10-compatible versions.

@cherniavskii

cherniavskii commented Jun 17, 2026

Copy link
Copy Markdown
Member

I don't think it's related to eslint.
The issue seems to be coming from pnpm dlx @mui/internal-code-infra@canary set-version-overrides that throws when detects resolutions in package.json, even though on v8.x we're using pnpm 10, not 11

cc @brijeshb42

UPD: opened a fix: #22865

@arminmeh

Copy link
Copy Markdown
Contributor

I don't think it's related to eslint. The issue seems to be coming from pnpm dlx @mui/internal-code-infra@canary set-version-overrides that throws when detects resolutions in package.json, even though on v8.x we're using pnpm 10, not 11

cc @brijeshb42

UPD: opened a fix: #22865

Is it better to update pnpm to v11 on v8.x as well?
There might be other issues down the road because of the version difference

@Janpot

Janpot commented Jun 18, 2026

Copy link
Copy Markdown
Member

Is it better to update pnpm to v11 on v8.x as well?

afaik overrides in pnpm-workspace.yaml is supported on v10. The set overrides script now just reject the resolutions field, which is a yarn property. I would have ported the v8 branch but I didn't realize this was breaking.

@arminmeh arminmeh merged commit 516809d into v8.x Jun 18, 2026
20 checks passed
@arminmeh arminmeh deleted the cherry-pick-22849-to-v8.x branch June 18, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. feature: Rendering layout Related to the data grid Rendering engine scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants