Skip to content

[charts-premium] Add geoFeatureKey to transform features identifier - #22848

Merged
JCQuintas merged 7 commits into
mui:masterfrom
alexfauquette:maps-id-matching
Jun 18, 2026
Merged

[charts-premium] Add geoFeatureKey to transform features identifier#22848
JCQuintas merged 7 commits into
mui:masterfrom
alexfauquette:maps-id-matching

Conversation

@alexfauquette

@alexfauquette alexfauquette commented Jun 17, 2026

Copy link
Copy Markdown
Member

Fix #22662

@alexfauquette
alexfauquette requested a review from JCQuintas as a code owner June 17, 2026 09:07
@alexfauquette alexfauquette added plan: Premium Impact at least one Premium user. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Jun 17, 2026
@code-infra-dashboard

code-infra-dashboard Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploy preview

Bundle size

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 🔺+81B(+0.02%) ▼-2B(0.00%)
@mui/x-charts-pro 🔺+69B(+0.01%) 🔺+26B(+0.02%)
@mui/x-charts-premium 🔺+166B(+0.03%) 🔺+41B(+0.02%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)
@mui/x-license 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

Total duration: 2,305.32 ms +7.96 ms(+0.3%) | Renders: 63 (+0)

Test Duration Renders
LineChart with date axis and big data amount 21.07 ms 🔺+3.91 ms(+22.8%) 2 (+0)
PieChart with big data amount 11.82 ms 🔺+2.67 ms(+29.2%) 2 (+0)
FunnelChart with big data amount 6.29 ms 🔺+1.16 ms(+22.6%) 2 (+0)
LineChart stacked area with multiple series 172.41 ms ▼-47.74 ms(-21.7%) 2 (+0)
ScatterChartPro with big data amount and zoomed in (single renderer) 9.01 ms ▼-2.80 ms(-23.7%) 2 (+0)

21 tests within noise — details

Metric alarms

Test Metric Change
PieChart with big data amount bench:paint 🔺 +3.93 ms

Check out the code infra dashboard for more information about this PR.

JCQuintas
JCQuintas approved these changes Jun 17, 2026
View reviewed changes
Comment thread docs/data/charts/map/map.md

{{"demo": "MapShapePlotDemo.js"}}

## Matching features with `geoFeatureKey`

@JCQuintas JCQuintas Jun 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a task to make this doc hierarchy better? 😆

Right now every item is flat

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 18, 2026
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 18, 2026
@JCQuintas
JCQuintas merged commit 5ccbe4e into mui:master Jun 18, 2026
21 checks passed
mbrookes pushed a commit to mbrookes/mui-x that referenced this pull request Jun 27, 2026
@alexfauquette @JCQuintas
[charts-premium] Add geoFeatureKey to transform features identifier (…
305ef05 
…mui#22848)

Co-authored-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JCQuintas JCQuintas JCQuintas approved these changes

Assignees

No one assigned

Labels

plan: Premium Impact at least one Premium user. scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[charts] Add key matching for maps

2 participants

@alexfauquette @JCQuintas