[chat] Sanitize message part URLs before using them as link href#22814
Open
Anexus5919 wants to merge 3 commits into
Open
[chat] Sanitize message part URLs before using them as link href#22814Anexus5919 wants to merge 3 commits into
Anexus5919 wants to merge 3 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Deploy previewhttps://deploy-preview-22814--material-ui-x.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
Contributor
Author
|
@rita-codes @michelengelen Kindly have a review on this pr. Thanks! |
Anexus5919
force-pushed
the
fix/chat-sanitize-part-urls
branch
from
c29bbb9 to
271c14c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
The default chat message part renderers in
@mui/x-chat-headlessplaced the untrustedpart.urldirectly into anchorhrefattributes. Message parts come from assistant/model output, tool results, or RAG source data, so ajavascript:URL flowed unmodified into the link. React 17 and 18 (both in the package's supported peer range) renderjavascript:URLs as written, so the link executes on click. React 19 neutralizes that vector, but no React version blocksdata:URLs at render time.This wraps every untrusted URL with the existing
safeUri()helper before assigning it tohref, in the default file and source-url renderers and in theSourceUrlPartandFilePartprimitives.safeUriwhitelistshttp,https,mailtoandtel, and returns an empty string otherwise. Imagesrcis left unchanged so legitimatedata:imageandblob:previews keep working, and because ajavascript:value in<img src>does not execute.Adds tests covering the four
hrefsinks plus a regression test that adata:image source is preserved.Closes #22726