ci: publish when the release PR is merged - #18
Merged
Conversation
Two manual steps were confusing: the release-please pull request is titled 'release 1.0.1' but only sets the version, tags it and creates a GitHub Release — npm publishing was a separate button, so merging the PR left npm on the previous version. release.yml now also triggers on a published GitHub Release, which only happens when a release PR is merged. Merging is therefore the single action that ships a version, with the version and changelog visible for review first. Manual dispatch stays for re-publishing after a failure or checking the tarball without shipping. The publish condition is explicit about the event rather than negating inputs.dry_run, which is undefined on a release event and would have read as 'not a dry run' by accident rather than intent. The tagging step is gone: release-please already created the tag that triggered the run. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The check rejected 'ci(release): ...' — 'main' was allowed for release-please's own PR title but 'release' was not, in a repository with a release workflow, a release-please config and a release PR. The rule worked exactly as intended; the vocabulary was incomplete. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
mschmicking
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-please PR is titled 'release 1.0.1' but only sets the version, tags it and creates a GitHub Release — npm publishing was a separate manual button. Merging the PR left npm on the old version, which is confusing.
release.ymlnow also triggers on a published GitHub Release, so merging the release PR is the single action that ships a version. Manual dispatch stays as a fallback.The publish condition checks
github.event_nameexplicitly rather than negatinginputs.dry_run, which is undefined on a release event.