Skip to content

fix(api): Remove throw when directOnly set to true #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanTheMan827 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −4
Open

fix(api): Remove throw when directOnly set to true #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions js/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@

return await HiFiClient.instance.query(relativePath);
} catch (err) {
if (options.directOnly) {
throw err;
}
console.warn(
`Direct fetch failed for ${relativePath}. Falling back to configured API instances...`,
err
Expand Down Expand Up @@ -451,7 +448,6 @@
// If direct query fails, fall back to hifi-api-compatible scoped searches (?s, ?a, ?al, ?v, ?p).
const response = await this.fetchWithRetry(`/search/?q=${encodeURIComponent(query)}`, {
...options,
directOnly: true,
});
const data = await response.json();

Expand Down Expand Up @@ -1946,7 +1942,7 @@
if (error.message === RATE_LIMIT_ERROR_MESSAGE) {
throw error;
}
throw new Error('Download failed. The stream may require a proxy.');

Check failure on line 1945 in js/api.js

View workflow job for this annotation

GitHub Actions / test

[chromium] js/api.test.ts > Track Downloads > 'Low' 

Error: Download failed. The stream may require a proxy.
 ❯ LosslessAPI.downloadTrack js/api.js:1945:18
 ❯ downloadTrack js/api.test.ts:109:15
 ❯ js/api.test.ts:282:21

Check failure on line 1945 in js/api.js

View workflow job for this annotation

GitHub Actions / test

[chromium] js/api.test.ts > Track Downloads > 'High' 

Error: Download failed. The stream may require a proxy.
 ❯ LosslessAPI.downloadTrack js/api.js:1945:18
 ❯ downloadTrack js/api.test.ts:109:15
 ❯ js/api.test.ts:282:21

Check failure on line 1945 in js/api.js

View workflow job for this annotation

GitHub Actions / test

[chromium] js/api.test.ts > Track Downloads > 'Lossless, but not really' 

Error: Download failed. The stream may require a proxy.
 ❯ LosslessAPI.downloadTrack js/api.js:1945:18
 ❯ downloadTrack js/api.test.ts:109:15
 ❯ js/api.test.ts:282:21

Check failure on line 1945 in js/api.js

View workflow job for this annotation

GitHub Actions / test

[chromium] js/api.test.ts > Track Downloads > 'Lossless (Unchanged)' 

Error: Download failed. The stream may require a proxy.
 ❯ LosslessAPI.downloadTrack js/api.js:1945:18
 ❯ downloadTrack js/api.test.ts:109:15
 ❯ js/api.test.ts:282:21

Check failure on line 1945 in js/api.js

View workflow job for this annotation

GitHub Actions / test

[chromium] js/api.test.ts > Track Downloads > 'HD Lossless (Unchanged)' 

Error: Download failed. The stream may require a proxy.
 ❯ LosslessAPI.downloadTrack js/api.js:1945:18
 ❯ downloadTrack js/api.test.ts:109:15
 ❯ js/api.test.ts:282:21

Check failure on line 1945 in js/api.js

View workflow job for this annotation

GitHub Actions / test

[chromium] js/api.test.ts > Track Downloads > 'Lossless (ALAC)' 

Error: Download failed. The stream may require a proxy.
 ❯ LosslessAPI.downloadTrack js/api.js:1945:18
 ❯ downloadTrack js/api.test.ts:109:15
 ❯ js/api.test.ts:282:21

Check failure on line 1945 in js/api.js

View workflow job for this annotation

GitHub Actions / test

[chromium] js/api.test.ts > Track Downloads > 'HD Lossless (ALAC)' 

Error: Download failed. The stream may require a proxy.
 ❯ LosslessAPI.downloadTrack js/api.js:1945:18
 ❯ downloadTrack js/api.test.ts:109:15
 ❯ js/api.test.ts:282:21

Check failure on line 1945 in js/api.js

View workflow job for this annotation

GitHub Actions / test

[chromium] js/api.test.ts > Track Downloads > 'Lossless (FLAC)' 

Error: Download failed. The stream may require a proxy.
 ❯ LosslessAPI.downloadTrack js/api.js:1945:18
 ❯ downloadTrack js/api.test.ts:109:15
 ❯ js/api.test.ts:282:21

Check failure on line 1945 in js/api.js

View workflow job for this annotation

GitHub Actions / test

[chromium] js/api.test.ts > Track Downloads > 'HD Lossless (FLAC)' 

Error: Download failed. The stream may require a proxy.
 ❯ LosslessAPI.downloadTrack js/api.js:1945:18
 ❯ downloadTrack js/api.test.ts:109:15
 ❯ js/api.test.ts:282:21

Check failure on line 1945 in js/api.js

View workflow job for this annotation

GitHub Actions / test

[chromium] js/api.test.ts > Track Downloads > 'Dolby Atmos' 

Error: Download failed. The stream may require a proxy.
 ❯ LosslessAPI.downloadTrack js/api.js:1945:18
 ❯ downloadTrack js/api.test.ts:109:15
 ❯ js/api.test.ts:282:21
}
}

Expand Down
Loading