test: make encryption tamper check deterministic - #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky AES GCM tamper test exposed by CI after the Zaati branding merge.
The test previously replaced only the final Base64URL character of the ciphertext. Because Base64URL is unpadded, that character can sometimes change only unused padding bits, leaving the decoded ciphertext bytes unchanged. In that case authentication correctly succeeds and
assert.throwsfails.This change decodes the ciphertext, flips one real bit in the first byte, and encodes it again. That guarantees the authenticated ciphertext bytes are actually modified and GCM rejection is deterministic.
Scope
Verification
CI should run the full quality gate, including
npm run test:coverage.