This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Fix build and a failing test#5
Open
mholtom wants to merge 1 commit into
Open
Conversation
|
This commit solved my issue, thanks 👍 |
Troublor
added a commit
to Troublor/go-z3
that referenced
this pull request
Oct 17, 2021
|
Thank you very much! This solved my issue, and using the MAKEFILE you provided reduced the previously lengthy build time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of z3 would fail to run the tests when built:
I have added a reference to the Math library with
-lmto fix this problem.When the tests built after applying the fix, there was a failing test:
Which I fixed to match the comment.
go-z3/z3_examples_test.go
Line 137 in 4cbedeb
Also with the additional constraint:
go-z3/z3_examples_test.go
Line 163 in 4cbedeb
Giving a new output:
go-z3/z3_examples_test.go
Lines 183 to 190 in 121f7c6