feat(nextjs): add 7 new Next.js best-practice rules from vercel-labs skill by devin-ai-integration[bot] · Pull Request #680 · millionco/react-doctor

devin-ai-integration · 2026-06-04T11:08:51Z

Summary

Four new Next.js rules derived from the vercel-labs/next-skills/next-best-practices skill, covering gaps in error handling, route handlers, and script optimization:

nextjs-error-boundary-missing-use-client (error) — error.tsx/global-error.tsx in /app/ without 'use client' silently fails to catch errors. Detection: filename pattern + hasDirective.

nextjs-global-error-missing-html-body (error) — global-error.tsx must render <html>+<body> since the root layout unmounts on error. Detection: walkAst for JSX tag names.

nextjs-no-default-export-in-route-handler (error) — export default in route.ts is silently ignored; Next.js only recognizes named HTTP method exports (GET, POST, etc.). Detection: ExportDefaultDeclaration + scan for named HTTP method exports via programHasNamedHttpMethodExport.

nextjs-no-google-analytics-script (warn) — Manual <script>/<Script> loading Google Analytics hurts performance; @next/third-parties/google loads optimally. Detection: src attribute matching GOOGLE_ANALYTICS_SCRIPT_PATTERN.

Also extracts ROUTE_HANDLER_HTTP_METHODS from local constant in server-hoist-static-io.ts into constants/nextjs.ts to deduplicate.

Link to Devin session: https://app.devin.ai/sessions/653e55fe57524520a26e1f8fa57eafa2
Requested by: @aidenybai

Note

Low Risk
Additive static-analysis rules and shared constants only; no runtime or security-sensitive behavior changes in consumer apps.

Overview
Adds seven Next.js-focused oxlint rules to react-doctor, wired through generated rule-registry entries and shared patterns in constants/nextjs.ts.

Error handling & App Router conventions: flags error.tsx / global-error.tsx under app/ without 'use client', and global-error.tsx missing <html> / <body> (via new fileContainsJsxElements helper). Route handlers: warns when route.ts uses export default (or re-exports default) without named GET/POST/… exports. Scripts & OG: errors on <Script> nested in <Head>, warns on manual GA script tags, @vercel/og imports, and runtime = 'edge' on opengraph/twitter image routes.

ROUTE_HANDLER_HTTP_METHODS is centralized in nextjs.ts and reused by server-hoist-static-io (replacing a local duplicate).

^{Reviewed by Cursor Bugbot for commit 161a6c5. Bugbot is set up for automated code reviews on this repo. Configure here.}

- nextjs-error-boundary-missing-use-client: error.tsx/global-error.tsx must have 'use client' - nextjs-global-error-missing-html-body: global-error.tsx must render <html> and <body> - nextjs-no-default-export-in-route-handler: route.ts must use named HTTP method exports - nextjs-no-google-analytics-script: use @next/third-parties instead of manual GA scripts Also extract ROUTE_HANDLER_HTTP_METHODS to constants/nextjs.ts to deduplicate with server-hoist-static-io.ts Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

devin-ai-integration · 2026-06-04T11:08:54Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment, CI, and merge conflict monitoring

pkg-pr-new · 2026-06-04T11:09:50Z

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@680

npm i https://pkg.pr.new/oxlint-plugin-react-doctor@680

npm i https://pkg.pr.new/react-doctor@680

commit: 161a6c5

github-actions · 2026-06-04T11:10:00Z

No React Doctor issues found. 🎉

_{Reviewed by React Doctor for commit 161a6c5.}

aidenybai · 2026-06-04T11:11:39Z

/rde parity

react-doctor-evals · 2026-06-04T11:11:42Z

✅ Parity OK — no diagnostic differences.

Baseline: main · This PR: devin/1780571023-nextjs-best-practice-rules (7cb2ba4)

ℹ️ Re-run this parity check by commenting /rde parity on this PR.

_{trace ca7f0fe0698b271ead59c6ee5abdc8a7 · rde}

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

devin-ai-integration

Devin Review found 1 potential issue.

View 4 additional findings in Devin Review.

devin-ai-integration · 2026-06-04T11:17:31Z

+export const GOOGLE_ANALYTICS_SCRIPT_PATTERN =
+  /google-analytics\.com|googletagmanager\.com\/gtag|www\.googletagmanager\.com/;


🟡 GOOGLE_ANALYTICS_SCRIPT_PATTERN regex matches Google Tag Manager scripts, producing misleading diagnostics

The third alternative in the regex (www\.googletagmanager\.com) matches all scripts from www.googletagmanager.com, including Google Tag Manager scripts (e.g. https://www.googletagmanager.com/gtm.js?id=GTM-XXXXX). These are not Google Analytics scripts, yet the rule fires with the message "Manual Google Analytics script blocks rendering" and recommends importing GoogleAnalytics from @next/third-parties/google. For a GTM script, the correct component would be GoogleTagManager. Additionally, this matching is inconsistent — GTM scripts from googletagmanager.com (without www.) are not caught, as confirmed by testing the regex.

Regex test results

www.googletagmanager.com/gtm.js?id=GTM-XXX → matches (false positive, it's GTM not GA)

googletagmanager.com/gtm.js?id=GTM-XXX → does NOT match (inconsistent)

www.googletagmanager.com/gtag/js?id=G-XXX → matches (correct, GA4)

www.google-analytics.com/analytics.js → matches (correct, old GA)

Suggested change

export const GOOGLE_ANALYTICS_SCRIPT_PATTERN =

/google-analytics\.com|googletagmanager\.com\/gtag|www\.googletagmanager\.com/;

export const GOOGLE_ANALYTICS_SCRIPT_PATTERN =

/google-analytics\.com|googletagmanager\.com\/gtag/;

Was this helpful? React with 👍 or 👎 to provide feedback.

Good catch — the third alternative matched all GTM scripts, not just GA. Fixed by narrowing to google-analytics\.com|googletagmanager\.com\/gtag which only matches GA4 (/gtag/js) and legacy GA (google-analytics.com).

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

…rt, no-edge-og-runtime - nextjs-no-script-in-head: <Script> inside <Head> is silently ignored - nextjs-no-vercel-og-import: use next/og instead of @vercel/og - nextjs-no-edge-og-runtime: avoid Edge runtime in OG image files Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

- fix: nextjs-no-script-in-head skip self-closing <Head /> to avoid false positives - refactor: extract fileContainsJsxElements to utils/ (one-utility-per-file) - refactor: global-error rule walks AST once instead of twice - refactor: no-edge-og-runtime hoists filename check to Program handler Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

- target/found → targetTagNames/foundTagNames in fileContainsJsxElements - tag → tagName in filter/map callbacks - REQUIRED_TAGS → REQUIRED_HTML_TAGS Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit aeec7ff. Configure here.}

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

devin-ai-integration Bot assigned aidenybai Jun 4, 2026

cursor Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread packages/oxlint-plugin-react-doctor/src/plugin/constants/nextjs.ts Outdated

fix: replace em dashes with periods in rule recommendations/messages

d77b116

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

devin-ai-integration Bot commented Jun 4, 2026

View reviewed changes

devin-ai-integration Bot and others added 2 commits June 4, 2026 11:18

fix: narrow GA regex to exclude GTM false positives

253417e

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

devin-ai-integration Bot changed the title ~~feat(nextjs): add 4 new Next.js best-practice rules from vercel-labs skill~~ feat(nextjs): add 7 new Next.js best-practice rules from vercel-labs skill Jun 4, 2026

cursor Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread packages/oxlint-plugin-react-doctor/src/plugin/rules/nextjs/nextjs-no-script-in-head.ts

devin-ai-integration Bot and others added 2 commits June 4, 2026 11:26

style: apply formatter to new rule files

92b337b

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

cursor Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread packages/oxlint-plugin-react-doctor/src/plugin/constants/nextjs.ts Outdated

devin-ai-integration Bot and others added 2 commits June 4, 2026 12:12

refactor: descriptive variable names per AGENTS.md

78f0f66

- target/found → targetTagNames/foundTagNames in fileContainsJsxElements - tag → tagName in filter/map callbacks - REQUIRED_TAGS → REQUIRED_HTML_TAGS Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

fix: OG_IMAGE_FILE_PATTERN match numeric suffixes (opengraph-image2.tsx)

aeec7ff

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

cursor Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread ...int-plugin-react-doctor/src/plugin/rules/nextjs/nextjs-no-default-export-in-route-handler.ts

fix: detect export { x as default } in route handler rule

161a6c5

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(nextjs): add 7 new Next.js best-practice rules from vercel-labs skill#680

feat(nextjs): add 7 new Next.js best-practice rules from vercel-labs skill#680
devin-ai-integration[bot] wants to merge 9 commits into
mainfrom
devin/1780571023-nextjs-best-practice-rules

devin-ai-integration Bot commented Jun 4, 2026 •

edited by cursor Bot

Loading

Uh oh!

devin-ai-integration Bot commented Jun 4, 2026

Uh oh!

pkg-pr-new Bot commented Jun 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

aidenybai commented Jun 4, 2026

Uh oh!

react-doctor-evals Bot commented Jun 4, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

devin-ai-integration Bot Jun 4, 2026

Uh oh!

devin-ai-integration Bot Jun 4, 2026

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		export const GOOGLE_ANALYTICS_SCRIPT_PATTERN =
		/google-analytics\.com\|googletagmanager\.com\/gtag\|www\.googletagmanager\.com/;

Conversation

devin-ai-integration Bot commented Jun 4, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

devin-ai-integration Bot commented Jun 4, 2026

🤖 Devin AI Engineer

Uh oh!

pkg-pr-new Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

aidenybai commented Jun 4, 2026

Uh oh!

react-doctor-evals Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

devin-ai-integration Bot commented Jun 4, 2026 •

edited by cursor Bot

Loading

pkg-pr-new Bot commented Jun 4, 2026 •

edited

Loading

github-actions Bot commented Jun 4, 2026 •

edited

Loading

react-doctor-evals Bot commented Jun 4, 2026 •

edited

Loading