-
Notifications
You must be signed in to change notification settings - Fork 387
feat: add Solid framework rules ported from eslint-plugin-solid #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aidenybai
wants to merge
18
commits into
main
Choose a base branch
from
cursor/port-solid-rules-to-oxc-798f
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b7acdec
feat: add Solid framework rules ported from eslint-plugin-solid
cursoragent d674b0a
refactor(solid): consolidate duplicated helpers per AGENTS.md DRY rule
cursoragent 1452f07
fix(solid-jsx-no-script-url): replace control-character regex with ex…
cursoragent 4c00c68
docs(solid-no-innerhtml): correct port comment about static-string ha…
cursoragent 224a3cc
feat(solid): add 7 new react-doctor-original rules + enhance 4 existing
aidenybai 9a70a85
fix(solid): address Bugbot findings — DRY isSetterCall, prototype-pol…
aidenybai e6dece1
fix(solid): add receiver check for console methods, extract shared ex…
aidenybai f81be90
fix(solid-no-react-specific-props): gate className/htmlFor check on D…
aidenybai 7bc57fb
feat(solid): add 7 new docs/community-derived rules
aidenybai d62a89f
refactor: deduplicate isDomElementName in isJsxAttributeOnIntrinsicHt…
aidenybai 9182f23
chore: format .agents/skills SKILL.md files
aidenybai 32163e5
feat(solid): port reactivity rule and jsx-no-undef from oxlint-plugin…
aidenybai 88e0585
test(solid): add tests for 9 previously untested rules
aidenybai 0b788e9
fix(solid): close parity gaps with upstream oxlint-plugin-solidjs
aidenybai 0685e7d
feat(solid): implement validate-jsx-nesting from scratch
aidenybai cf9cbf8
feat(solid): implement jsx-uses-vars for use:directive tracking
aidenybai 7991afe
fix(solid-reactivity): consume references to prevent duplicate report…
aidenybai f371406
fix(solid): resolve Bugbot findings — style-prop line-height FP, effe…
aidenybai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import type { PackageJson } from "../types/index.js"; | ||
|
|
||
| const SOLID_PACKAGES = new Set(["solid-js", "solid-start", "@solidjs/start", "@solidjs/router"]); | ||
|
|
||
| export const hasSolid = (packageJson: PackageJson): boolean => { | ||
| const allDependencies = { | ||
| ...packageJson.peerDependencies, | ||
| ...packageJson.dependencies, | ||
| ...packageJson.devDependencies, | ||
| }; | ||
| return Object.keys(allDependencies).some((packageName) => SOLID_PACKAGES.has(packageName)); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hasSolid doc comment claims unimplemented workspace traversal
Medium Severity
The doc comment on
hasSolidexplicitly states it detects Solid "even on monorepos where the entry-pointpackage.jsonis a different framework but a sibling workspace targets SolidJS." However,hasSolid(packageJson)only inspects the single passed-inpackage.json— there is no workspace traversal logic (unlikehasReactNativeWorkspaceAnywherefor the analogoushasReactNativeWorkspacefield). In monorepos where Solid lives only in a child workspace, thesolidcapability will never be set and all Solid rules will be silently skipped.Additional Locations (1)
packages/core/src/project-info/has-solid.ts#L4-L12Reviewed by Cursor Bugbot for commit 8bf6334. Configure here.