Skip to content

feat(oxlint-plugin): add client-prefer-keybind-library rule #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(oxlint-plugin): add client-prefer-keybind-library rule #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6749b2
feat(oxlint-plugin): add `client-prefer-keybind-library` rule
devin-ai-integration[bot] May 25, 2026
5a9c8ae
style: apply formatter to rule file
devin-ai-integration[bot] May 25, 2026
ed5221b
refactor: address review — category to Architecture, remove library skip
devin-ai-integration[bot] May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/oxlint-plugin-react-doctor/src/plugin/constants/dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,5 @@ export const EXTERNAL_SYNC_OBSERVER_CONSTRUCTORS = new Set([
]);

export const STORAGE_OBJECTS = new Set(["localStorage", "sessionStorage"]);

export const KEYBOARD_EVENT_NAMES = new Set(["keydown", "keyup", "keypress"]);
15 changes: 15 additions & 0 deletions packages/oxlint-plugin-react-doctor/src/plugin/rule-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { checkedRequiresOnchangeOrReadonly } from "./rules/react-builtins/checke
import { clickEventsHaveKeyEvents } from "./rules/a11y/click-events-have-key-events.js";
import { clientLocalstorageNoVersion } from "./rules/client/client-localstorage-no-version.js";
import { clientPassiveEventListeners } from "./rules/client/client-passive-event-listeners.js";
import { clientPreferKeybindLibrary } from "./rules/client/client-prefer-keybind-library.js";
import { controlHasAssociatedLabel } from "./rules/a11y/control-has-associated-label.js";
import { noBoldHeading } from "./rules/react-ui/no-bold-heading.js";
import { noEmDashInJsxText } from "./rules/react-ui/no-em-dash-in-jsx-text.js";
Expand Down Expand Up @@ -562,6 +563,20 @@ export const reactDoctorRules = [
category: "Performance",
},
},
{
key: "react-doctor/client-prefer-keybind-library",
id: "client-prefer-keybind-library",
source: "react-doctor",
originallyExternal: false,
framework: "global",
category: "Architecture",
severity: "warn",
rule: {
...clientPreferKeybindLibrary,
framework: "global",
category: "Architecture",
},
},
{
key: "react-doctor/control-has-associated-label",
id: "control-has-associated-label",
Expand Down
Loading
Loading