Add PyQt6 multi-file GUI for MarkItDown - #2325
Add PyQt6 multi-file GUI for MarkItDown#2325Rahul Pawar (rahulpwar654) wants to merge 3 commits into
Conversation
|
@microsoft-github-policy-service agree |
Razin M (R-zin)
left a comment
There was a problem hiding this comment.
for source_file in self._selected_files:
result = converter.convert(str(source_file))
If you use this then when a large PDF or any file is queued for conversion it uses the same thread for the Qt GUI as well (The GUI can freeze) so I think you should spawn a Worker Thread which will handle MarkItDown.convert() function which will be on separate thread and when it finishes it can update the Qt thread. You can even add a progress bar in GUI also.
Razin M (R-zin)
left a comment
There was a problem hiding this comment.
for source_file in self._selected_files:
result = converter.convert(str(source_file))
If you use this then when a large PDF or any file is queued for conversion it uses the same thread for the Qt GUI as well (The GUI can freeze) so I think you should spawn a Worker Thread which will handle MarkItDown.convert() function which will be on separate thread and when it finishes it can update the Qt thread. You can even add a progress bar in GUI also.
|
Changes in _qt_gui.py: MarkItDown.convert() now runs inside a QObject worker moved to a QThread. |
|
Thank you for your contribution, but we cannot accept additional applications, services, or servers. With the exception of the MCP package, this repository is intended to provide Python libraries that can be incorporated into other systems. If you’re interested in providing a web service, API, or graphical application for MarkItDown, I’d encourage you to maintain it as a separate package or project that depends on MarkItDown. |
markitdown-guidesktop app implementation