fix(doc-intel): default api_version to None in DocumentIntelligenceConverter - #2267
Merged
afourney merged 3 commits intoSep 2, 2026
Merged
Conversation
…nverter Do not set a default api_version string in DocumentIntelligenceConverter. If api_version is omitted or None, avoid passing api_version kwarg to DocumentIntelligenceClient so Azure SDK uses its native default version. Fixes microsoft#1904
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the reported requirement and covers both affected initialization paths.
Pull request overview
Updates Azure Document Intelligence integration to defer API-version selection to the SDK unless explicitly configured.
Changes:
- Defaults
api_versiontoNoneand conditionally forwards it. - Adds tests for default and custom API versions.
File summaries
| File | Description |
|---|---|
packages/markitdown/src/markitdown/converters/_doc_intel_converter.py |
Defers default API-version selection to the Azure SDK. |
packages/markitdown/tests/test_docintel_html.py |
Verifies omitted and explicit API-version behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DocumentIntelligenceConverterpreviously set a defaultapi_version="2024-07-31-preview". This prevented users from using Azure Document Intelligence SDK's native default API version (e.g.2024-11-30).This PR changes the default
api_versionparameter inDocumentIntelligenceConverter.__init__toNoneand passesapi_versiontoDocumentIntelligenceClientonly when explicitly specified.Fixes #1904