fix: truncate uppercase data image URIs - #2122
Merged
afourney merged 3 commits intoSep 2, 2026
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
🟡 Changes recommended
Lowercasing the entire potentially large URI introduces avoidable time and memory overhead.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Makes data-URI image truncation case-insensitive while preserving keep_data_uris=True.
Changes:
- Detects uppercase and mixed-case
data:schemes. - Adds regression coverage for truncation and preservation.
File summaries
| File | Description |
|---|---|
_markdownify.py |
Adds case-insensitive scheme detection. |
test_module_misc.py |
Tests uppercase data-image URIs. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
Before this change, converting HTML with an image source like DATA:image/png;base64,AAAA emitted the full payload even though keep_data_uris defaults to False. Lowercase data:image sources were truncated, so uppercase schemes bypassed the intended behavior.
Tests