Hide vertical tabs setting until stabilized - #876
Merged
Conversation
Temporarily remove the tab layout selector from the Appearance settings page while vertical tabs stabilize. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 88cfc949-6c2a-4487-95bc-15fb8f0e2c1b
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change cleanly removes only the UI element (via XAML comment) without impacting the underlying setting/model and does not introduce compile-time references to removed named elements.
Pull request overview
This PR hides the “Tab Layout (horizontal vs vertical)” selector from the Global Appearance settings UI while preserving the underlying vertical-tabs implementation and setting in the ViewModel/settings model.
Changes:
- Commented out the
TabLayoutSettingContainerinGlobalAppearance.xamlto remove the UI control. - Added a TODO note indicating the setting should be restored once vertical tabs stabilize.
File summaries
| File | Description |
|---|---|
| src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml | Comments out the Tab Layout selector block and adds a TODO for re-enabling later. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Yuandi (DDKinger)
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation