Settings polish: keep Add New as the final custom endpoint row - #856
Merged
Conversation
Show saved endpoints as rows and keep the add form as the final row, removing the separate add and cancel entry points. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c104e757-044f-427f-8959-532d09dd5a78
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated empty-state add flow is now hidden behind a collapsed expander by default, and related ViewModel API surface is left unused, which risks a discoverability regression and ongoing maintenance cost.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR refactors the “Custom endpoint / BYOK” portion of the AI Agents settings page to present saved custom endpoints as removable rows while keeping the “Base URL / Model ID / API key” entry form consistently available as the final row, and removes now-obsolete localized strings tied to the previous “Add endpoint / Cancel” UI.
Changes:
- Consolidates the custom provider UI into a single
Expanderby removing the separate empty-state header + Add button and keeping the entry form always present. - Removes the redundant Cancel action from the custom provider form UI.
- Deletes the localized resource keys for the removed Add/Cancel buttons across locales.
File summaries
| File | Description |
|---|---|
| src/cascadia/TerminalSettingsEditor/AIAgents.xaml | Removes empty-state header/add button and makes the expander the single container with the add form always present. |
| src/cascadia/TerminalSettingsEditor/AIAgents.cpp | Drops code-behind references to removed empty-state UI elements. |
| src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/qps-ploc/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/qps-ploca/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/qps-plocm/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/sr-Cyrl-RS/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/uk-UA/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
| src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw | Removes obsolete AIAgents_CustomProviderAdd/Cancel strings. |
Review details
- Files reviewed: 18/18 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vertically center the expander header and separate saved endpoint rows from the final add form with bottom borders. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c104e757-044f-427f-8959-532d09dd5a78
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are localized to the settings UI/resources, remove obsolete strings consistently across locales, and do not introduce any verified functional or build issues.
Review details
- Files reviewed: 18/18 changed files
- Comments generated: 0 new
- Review effort level: Lite
Yuandi (DDKinger)
changed the title
Keep Add New as the final row and reveal the endpoint fields only while the user is adding a provider. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c104e757-044f-427f-8959-532d09dd5a78
Yuandi (DDKinger)
changed the title
Use consistent row heights and symmetric padding so saved endpoints, Remove, and Add New align vertically. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c104e757-044f-427f-8959-532d09dd5a78
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Multiple .resw files introduce inconsistent indentation (and fr-FR has a grammatical issue) that should be corrected before merging.
Review details
Suppressed comments (16)
Previously missed (15) — in code that hasn't changed since the last review.
src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw:3014
- The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw:3014 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw:3015 - The French label "Ajouter nouveau" is grammatically incorrect for a button caption and reads unnatural in UI.
src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw:3014 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw:3014 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw:3074 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw:3057 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/qps-ploc/Resources.resw:3005 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/qps-ploca/Resources.resw:3005 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/qps-plocm/Resources.resw:3005 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw:3057 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/sr-Cyrl-RS/Resources.resw:3072 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/uk-UA/Resources.resw:2718 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw:3074 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw:3014 - The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw:3126
- The entries here are indented inconsistently compared to surrounding resources (extra indentation on CustomProviderAdd and missing indentation on CustomProviderSave), which makes the .resw harder to maintain and review.
<data name="AIAgents_CustomProviderAdd.Content" xml:space="preserve">
<value>Add New</value>
<comment>Button in the final custom provider row that reveals the fields for adding another endpoint.</comment>
</data>
<data name="AIAgents_CustomProviderSave.Content" xml:space="preserve">
- Files reviewed: 18/18 changed files
- Comments generated: 0 new
- Review effort level: Lite
Let the primary endpoint row fill available height and center Add New within a full-height grid. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c104e757-044f-427f-8959-532d09dd5a78
Give saved endpoints and Add New the standard 64-pixel settings row height with symmetric padding for visible vertical centering. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c104e757-044f-427f-8959-532d09dd5a78
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The remaining feedback is limited to minor .resw indentation normalization in the touched resource blocks (with self-contained suggested fixes).
Review details
Suppressed comments (16)
Previously missed (15) — in code that hasn't changed since the last review.
src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw:3014
- The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw:3014 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw:3015 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw:3014 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw:3014 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw:3074 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw:3057 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/qps-ploc/Resources.resw:3005 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/qps-ploca/Resources.resw:3005 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/qps-plocm/Resources.resw:3005 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw:3057 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/sr-Cyrl-RS/Resources.resw:3072 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/uk-UA/Resources.resw:2718 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw:3074 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw:3014 - The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw:3126
- The opening tags for the Add/Save resources are mis-indented (4 spaces for Add, 0 for Save) compared to surrounding entries, which creates unnecessary churn in .resw diffs and makes the XML harder to scan. Normalize these to the same indentation level as the other elements.
<data name="AIAgents_CustomProviderAdd.Content" xml:space="preserve">
<value>Add New</value>
<comment>Button in the final custom provider row that reveals the fields for adding another endpoint.</comment>
</data>
<data name="AIAgents_CustomProviderSave.Content" xml:space="preserve">
- Files reviewed: 18/18 changed files
- Comments generated: 0 new
- Review effort level: Lite
Yuandi (DDKinger)
changed the title
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Multiple updated .resw entries introduce inconsistent indentation that should be corrected to avoid noisy diffs and maintain consistent resource formatting.
Review details
Suppressed comments (16)
Previously missed (15) — in code that hasn't changed since the last review.
src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw:3014
- The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw:3014 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw:3015 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw:3014 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw:3014 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw:3074 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw:3057 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/qps-ploc/Resources.resw:3005 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/qps-ploca/Resources.resw:3005 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/qps-plocm/Resources.resw:3005 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw:3057 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/sr-Cyrl-RS/Resources.resw:3072 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/uk-UA/Resources.resw:2718 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw:3074 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw:3014 - The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw:3126
- The blocks for AIAgents_CustomProviderAdd.Content / AIAgents_CustomProviderSave.Content have inconsistent indentation (extra indent on Add, none on Save) compared to surrounding entries, which makes future diffs noisy. Align these to the standard two-space indent used elsewhere in the .resw file.
<data name="AIAgents_CustomProviderAdd.Content" xml:space="preserve">
<value>Add New</value>
<comment>Button in the final custom provider row that reveals the fields for adding another endpoint.</comment>
</data>
<data name="AIAgents_CustomProviderSave.Content" xml:space="preserve">
- Files reviewed: 18/18 changed files
- Comments generated: 0 new
- Review effort level: Lite
Offset WinUI's default vertical content padding so saved endpoints, Remove, and Add New are centered in their rows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c104e757-044f-427f-8959-532d09dd5a78
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is primarily UI/layout and resource-string updates, and the only issue found is minor .resw formatting consistency.
Review details
Suppressed comments (1)
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw:3126
- The AIAgents_CustomProviderAdd/Save blocks have inconsistent indentation (extra indent on the Add block and missing indent on the subsequent Save block), which makes Resources.resw formatting inconsistent and tends to create noisy diffs. Re-indent these entries to match the surrounding two-space indentation (and apply the same normalization across the other locale .resw files touched in this PR).
<data name="AIAgents_CustomProviderAdd.Content" xml:space="preserve">
<value>Add New</value>
<comment>Button in the final custom provider row that reveals the fields for adding another endpoint.</comment>
</data>
<data name="AIAgents_CustomProviderSave.Content" xml:space="preserve">
- Files reviewed: 18/18 changed files
- Comments generated: 0 new
- Review effort level: Lite
Keep the compact provider rows from main and rely on the Expander padding fix for correct vertical alignment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c104e757-044f-427f-8959-532d09dd5a78
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Several localized “Add New” strings are mistranslated/ungrammatical (user-visible regression) and should be corrected before approval.
Review details
Suppressed comments (4)
Previously missed (3) — in code that hasn't changed since the last review.
src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw:3012
- The fr-FR string “Ajouter nouveau” is grammatically incorrect (missing an article/noun). Since this button starts adding another custom endpoint, keep the prior, correct wording rather than an ungrammatical abbreviation.
src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw:3054 - The ru-RU translation for the Add New row now says “Добавить нового поставщика” (add a new provider), but this action is for adding another custom provider endpoint (per the key name and the English comment). This wording is likely inaccurate compared to the previous “конечную точку” terminology used elsewhere in the same section.
src/cascadia/TerminalSettingsEditor/Resources/sr-Cyrl-RS/Resources.resw:3069 - The sr-Cyrl-RS translation for the Add New row currently reads “Додај новог добављача” (add a new provider), but this control is for adding another custom provider endpoint (as indicated by the resource key and English comment). This appears to be a mistranslation compared to the prior “крајњу тачку” wording.
src/cascadia/TerminalSettingsEditor/AIAgents.xaml:196
- CustomModelProvidersExpander is no longer bound to ViewModel.ShowCustomModelProvidersExpander, but the view model still computes and notifies this property (and it’s exposed in the IDL). If the expander is now meant to be always visible, consider removing ShowCustomModelProvidersExpander and its related notifications/IDL to avoid dead UI state and redundant change notifications.
<muxc:Expander x:Name="CustomModelProvidersExpander"
Margin="0,4,0,0"
HorizontalAlignment="Stretch"
HorizontalContentAlignment="Stretch"
IsExpanded="{x:Bind ViewModel.IsCustomModelProvidersExpanded, Mode=TwoWay}">
- Files reviewed: 18/18 changed files
- Comments generated: 0 new
- Review effort level: Lite
Reuse the established endpoint-specific translations so the final-row action is grammatical and accurately describes the item being added. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c104e757-044f-427f-8959-532d09dd5a78
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several non-en-US locales still display the old “Add endpoint” label for the final-row CTA, making the UI inconsistent with the new “Add New” design and the PR’s stated localization intent.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (11)
Previously missed (11) — in code that hasn't changed since the last review.
src/cascadia/TerminalSettingsEditor/AIAgents.xaml:214
- Using a negative Margin (0,-16,0,-16) to cancel Expander body padding is brittle (theme/style changes can break layout and focus bounds). Prefer overriding the WinUI ExpanderContentPadding resource locally instead, then keep the StackPanel margin at 0.
src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw:3012 - en-US changes AIAgents_CustomProviderAdd.Content to "Add New", but this locale still shows the old "Add endpoint" wording. This contradicts the PR goal of showing an "Add New" final row and can make the UI inconsistent across languages; please update the localized accordingly.
src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw:3012 - en-US changes AIAgents_CustomProviderAdd.Content to "Add New", but this locale still shows the old "Add endpoint" wording. This contradicts the PR goal of showing an "Add New" final row and can make the UI inconsistent across languages; please update the localized accordingly.
src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw:3013 - en-US changes AIAgents_CustomProviderAdd.Content to "Add New", but this locale still shows the old "Add endpoint" wording. This contradicts the PR goal of showing an "Add New" final row and can make the UI inconsistent across languages; please update the localized accordingly.
src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw:3012 - en-US changes AIAgents_CustomProviderAdd.Content to "Add New", but this locale still shows the old "Add endpoint" wording. This contradicts the PR goal of showing an "Add New" final row and can make the UI inconsistent across languages; please update the localized accordingly.
src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw:3012 - en-US changes AIAgents_CustomProviderAdd.Content to "Add New", but this locale still shows the old "Add endpoint" wording. This contradicts the PR goal of showing an "Add New" final row and can make the UI inconsistent across languages; please update the localized accordingly.
src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw:3072 - en-US changes AIAgents_CustomProviderAdd.Content to "Add New", but this locale still shows the old "Add endpoint" wording. This contradicts the PR goal of showing an "Add New" final row and can make the UI inconsistent across languages; please update the localized accordingly.
src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw:3055 - en-US changes AIAgents_CustomProviderAdd.Content to "Add New", but this locale still shows the old "Add endpoint" wording. This contradicts the PR goal of showing an "Add New" final row and can make the UI inconsistent across languages; please update the localized accordingly.
src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw:3055 - en-US changes AIAgents_CustomProviderAdd.Content to "Add New", but this locale still shows the old "Add endpoint" wording. This contradicts the PR goal of showing an "Add New" final row and can make the UI inconsistent across languages; please update the localized accordingly.
src/cascadia/TerminalSettingsEditor/Resources/sr-Cyrl-RS/Resources.resw:3070 - en-US changes AIAgents_CustomProviderAdd.Content to "Add New", but this locale still shows the old "Add endpoint" wording. This contradicts the PR goal of showing an "Add New" final row and can make the UI inconsistent across languages; please update the localized accordingly.
src/cascadia/TerminalSettingsEditor/Resources/uk-UA/Resources.resw:2716 - en-US changes AIAgents_CustomProviderAdd.Content to "Add New", but this locale still shows the old "Add endpoint" wording. This contradicts the PR goal of showing an "Add New" final row and can make the UI inconsistent across languages; please update the localized accordingly.
- Files reviewed: 18/18 changed files
- Comments generated: 2
- Review effort level: Lite
Kai Tao (vanzue)
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Newas the final row and reveal the Base URL, Model ID, and API key fields only after it is selectedAdd and SelectorCancelValidation
TerminalSettingsEditorwith the project-local DebugbxcommandRelated to #789 and #792.