Remove IT badge from built-in slash commands - #850
Merged
Conversation
Keep provider badges only for slash commands advertised by the active ACP agent. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to UI rendering, updates the unit test to assert the new behavior, and has no remaining correctness issues based on the updated call sites.
Pull request overview
This PR updates the WTA command popup rendering so that built-in (client) slash commands no longer display an [IT] source badge, while ACP-advertised (agent) commands continue to show the active agent badge. This aligns the UI’s “source” indicator with “agent-provided” rather than “built-in vs agent”.
Changes:
- Remove the built-in
[IT]badge by only computing/rendering source badges forCommandCandidate::Agent. - Update badge rendering to return
Option<Span>and useVec::extendto conditionally append it. - Rename/update the focused unit test to match the new behavior.
File summaries
| File | Description |
|---|---|
| tools/wta/src/ui/command_popup.rs | Stops rendering a source badge for client commands; keeps agent badge rendering and updates the corresponding unit test. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Yuandi (DDKinger)
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[IT]source badge from built-in slash commandsTesting
cargo test --target x86_64-pc-windows-msvc --manifest-path tools/wta/Cargo.toml source_badges_only_identify_agent_commands