Skip to content

Commit fc449b6

Browse files
haonantttHaonan Tang (from Dev Box)Copilot
authored
Refine the FRE settings wordings (#878)
* Replace FRE error toggles with a dropdown * Update FRE settings wording * Reorder FRE settings * Modify title * Update FRE setup wording and remove inline hints * Stabilize FRE settings layout width * Rename FRE primary button to Get Started * Localize updated FRE settings across all locales * Synchronize FRE translator comments across locales Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 983cc47d-6f23-4c84-9a54-1a60ecaaf607 * Clarify FRE error detection wording Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 983cc47d-6f23-4c84-9a54-1a60ecaaf607 --------- Co-authored-by: Haonan Tang (from Dev Box) <haonantang@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 983cc47d-6f23-4c84-9a54-1a60ecaaf607
1 parent efd10cf commit fc449b6

93 files changed

Lines changed: 4322 additions & 4403 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/cascadia/TerminalApp/FreOverlay.cpp

Lines changed: 131 additions & 100 deletions
Large diffs are not rendered by default.

src/cascadia/TerminalApp/FreOverlay.h

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,8 @@ namespace winrt::TerminalApp::implementation
4141
const winrt::Windows::UI::Xaml::RoutedEventArgs& args);
4242
void _OnCloseButtonClick(const winrt::Windows::Foundation::IInspectable& sender,
4343
const winrt::Windows::UI::Xaml::RoutedEventArgs& args);
44-
void _OnAgentSelectionChanged(const winrt::Windows::Foundation::IInspectable& sender,
45-
const winrt::Windows::UI::Xaml::Controls::SelectionChangedEventArgs& args);
46-
void _OnSessionManagementToggled(const winrt::Windows::Foundation::IInspectable& sender,
47-
const winrt::Windows::UI::Xaml::RoutedEventArgs& args);
48-
void _OnAutoDetectToggled(const winrt::Windows::Foundation::IInspectable& sender,
49-
const winrt::Windows::UI::Xaml::RoutedEventArgs& args);
44+
void _OnSettingsFormScrollerSizeChanged(const winrt::Windows::Foundation::IInspectable& sender,
45+
const winrt::Windows::UI::Xaml::SizeChangedEventArgs& args);
5046

5147
// No-op kept for IDL compatibility.
5248
void ResetDragOffset();
@@ -119,10 +115,16 @@ namespace winrt::TerminalApp::implementation
119115
// editing, and parks focus on the help link.
120116
void _FinalizeProblemDisplay(const std::wstring& url);
121117

122-
// Apply the detection→suggestion master-detail dependency: detection
123-
// off turns the suggestion toggle off and disables it; detection on
124-
// re-enables it (preserving the stored value).
125-
void _UpdateSuggestionEnabledState();
118+
enum class ErrorDetectionMode : int32_t
119+
{
120+
Detect = 0,
121+
DetectAndFix = 1,
122+
Off = 2,
123+
};
124+
125+
ErrorDetectionMode _CurrentErrorDetectionMode();
126+
void _SetErrorDetectionMode(ErrorDetectionMode mode);
127+
void _UpdateSettingsFormWidth();
126128

127129
// (Re)build the agent dropdown from the GPO-filtered registry, labeling
128130
// each entry with its live install state. Safe to call repeatedly (e.g.

src/cascadia/TerminalApp/FreOverlay.xaml

Lines changed: 73 additions & 209 deletions
Large diffs are not rendered by default.

src/cascadia/TerminalApp/Resources/af-ZA/Resources.resw

Lines changed: 48 additions & 43 deletions
Large diffs are not rendered by default.

src/cascadia/TerminalApp/Resources/am-ET/Resources.resw

Lines changed: 48 additions & 43 deletions
Large diffs are not rendered by default.

src/cascadia/TerminalApp/Resources/ar-SA/Resources.resw

Lines changed: 48 additions & 43 deletions
Large diffs are not rendered by default.

src/cascadia/TerminalApp/Resources/as-IN/Resources.resw

Lines changed: 41 additions & 36 deletions
Large diffs are not rendered by default.

src/cascadia/TerminalApp/Resources/az-Latn-AZ/Resources.resw

Lines changed: 48 additions & 43 deletions
Large diffs are not rendered by default.

src/cascadia/TerminalApp/Resources/bg-BG/Resources.resw

Lines changed: 48 additions & 43 deletions
Large diffs are not rendered by default.

src/cascadia/TerminalApp/Resources/bn-IN/Resources.resw

Lines changed: 41 additions & 36 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)