[microsoft/main] Update common Docker engineering infrastructure with latest#637
Open
dotnet-docker-bot wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared Azure Pipelines “publish” infrastructure to support an additional mode for publishing merged image info: publishing it as an OCI artifact to the publish registry rather than committing it to the GitHub versions repo. This fits into the repo’s eng/docker-tools pipeline templates by adding a single new boolean parameter and threading it through the stage/job wrapper templates to the publish job implementation.
Changes:
- Introduces a new
useOciArtifactForImageInfoparameter (defaultfalse) to control how merged image info is published. - Threads
useOciArtifactForImageInfothrough the common publish stage and the .NET-specific wrapper templates. - Updates the publish job to conditionally run
publishImageInfoArtifact(OCI artifact path) vs the existingpublishImageInfo(git commit path).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/docker-tools/templates/stages/publish.yml | Adds useOciArtifactForImageInfo parameter and passes it to the publish job template. |
| eng/docker-tools/templates/stages/dotnet/publish.yml | Adds the parameter to the .NET publish wrapper and forwards it to the common publish stage template. |
| eng/docker-tools/templates/stages/dotnet/build-test-publish-repo.yml | Adds the parameter at the repo-level .NET pipeline wrapper and forwards it to the publish stage template. |
| eng/docker-tools/templates/jobs/publish.yml | Implements the conditional behavior: publish merged image info as an OCI artifact when enabled, otherwise keep committing to the versions repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the common Docker engineering infrastructure with latest changes from the dotnet/docker-tools repo.