Fix keyboard focus not reaching DataGrid column headers#791
Open
wnvko-msft wants to merge 1 commit into
Open
Conversation
dipeshmsft
added
the
Accessibility
Member
|
The change looks good. However, is there a way we can make the focus visual around the header more visible. As of now, it is getting clipped, and the A11y team will push back for this. 
|
himgoyalmicro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WPF Gallery → Collections → DataGrid: while navigating with the keyboard, focus skipped the column headings, so keyboard-only users could not reach them.
DataGridColumnHeaderis non-focusable by default.This adds a
ColumnHeaderStyleon the sample DataGrid that setsFocusable=True(based on the Fluent default style), so the column headings receive keyboard focus during navigation. The displayed XamlCode is updated to match.Testing: Navigate to Collections → DataGrid and Tab/arrow into the table - focus now lands on the column headers.
Microsoft Reviewers: Open in CodeFlow