[Settings] Eliminate XamlIndexBuilder parallel build race - #50347
Draft
Yu Leng (moooyo) wants to merge 1 commit into
Draft
[Settings] Eliminate XamlIndexBuilder parallel build race#50347Yu Leng (moooyo) wants to merge 1 commit into
Yu Leng (moooyo) wants to merge 1 commit into
Conversation
Yu Leng (moooyo)
marked this pull request as draft
September 3, 2026 17:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Eliminates the Settings XamlIndexBuilder parallel-build race by making the tool a build-only ProjectReference owned by PowerToys.Settings.
The change also:
PR Checklist
Detailed Description of the Pull Request / Additional comments
PowerToys.Settings and Settings.UI.XamlIndexBuilder were both scheduled independently by the solution, while Settings also invoked a second AnyCPU build of the same project. The nested build's AfterBuild target deleted obj/x64 while the solution build was still using it, causing MSB3231 and CS2012 failures.
The builder is now a pure build tool. A non-runtime ProjectReference establishes one dependency in the MSBuild graph and exposes the tool output to a Settings-owned generation target. Generated JSON is kept under a platform/configuration-specific obj directory and copied to the same Assets/Settings destination as before.
Validation Steps Performed