Skip to content

[File Explorer Add-Ons] Combine all providers into one provider - #50252

Open
Noraa Junker (noraa-junker) wants to merge 6 commits into
mainfrom
feature/consolidate-file-explorer-modules
Open

[File Explorer Add-Ons] Combine all providers into one provider#50252
Noraa Junker (noraa-junker) wants to merge 6 commits into
mainfrom
feature/consolidate-file-explorer-modules

Conversation

@noraa-junker

@noraa-junker Noraa Junker (noraa-junker) commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

This PR incoperates changes that were originally proposed in #43714

This PR removes all CPP File Explorer preview handlers and thumbnail providers and merges them into one: FileExplorerDLLExporter.

This reduces duplicate code and files in the output folder.

Furthermore the solution folder "previewpane" was renamed to "File Explorer add-ons" to match the actual module name

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@noraa-junker

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

@github-actions github-actions Bot added the Product-File Explorer Power Toys that touch explorer like Preview Pane label Aug 30, 2026
@noraa-junker Noraa Junker (noraa-junker) added the Needs-Review This Pull Request awaits the review of a maintainer. label Aug 30, 2026
@github-actions github-actions Bot removed the Needs-Review This Pull Request awaits the review of a maintainer. label Aug 30, 2026
@noraa-junker Noraa Junker (noraa-junker) added the Needs-Review This Pull Request awaits the review of a maintainer. label Aug 30, 2026
@noraa-junker
Noraa Junker (noraa-junker) marked this pull request as ready for review August 30, 2026 16:59
@noraa-junker
Noraa Junker (noraa-junker) requested a review from a team as a code owner August 30, 2026 16:59
@github-actions github-actions Bot removed the Needs-Review This Pull Request awaits the review of a maintainer. label Aug 30, 2026
@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

🧭 PR intake

Visual evidence: Not needed — The changed files do not indicate a visible UI change. No visual evidence is expected.

Recommendation

Link the issue this PR fixes using a closing keyword such as Closes #123.

✅ Ready for review

This PR passed the automated intake checks and is ready for maintainer review.

Automated PR intake; PowerToys maintainers make final decisions.

@MuyuanMS Muyuan Li (MuyuanMS) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve the provider-specific resize events for the PDF, QOI, and SVG preview handlers in the consolidated exporter.

Comment thread src/modules/previewpane/FileExplorerDllExporter/dllmain.cpp
@MuyuanMS Muyuan Li (MuyuanMS) self-assigned this Sep 1, 2026
@github-actions github-actions Bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Ready for review labels Sep 1, 2026
@github-actions github-actions Bot added Ready for review and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jay-o-Way

Copy link
Copy Markdown
Collaborator

Screenshot_20260903-190532~2.jpg 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product-File Explorer Power Toys that touch explorer like Preview Pane Ready for review

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants