Skip to content

(refactor): Migrate all internal ITelemetryLoggerExt use to TelemetryLoggerExt#27484

Merged
MarioJGMsoft merged 3 commits into
microsoft:mainfrom
MarioJGMsoft:marioja/ITelemetryLoggerExtCleanup
Jun 5, 2026
Merged

(refactor): Migrate all internal ITelemetryLoggerExt use to TelemetryLoggerExt#27484
MarioJGMsoft merged 3 commits into
microsoft:mainfrom
MarioJGMsoft:marioja/ITelemetryLoggerExtCleanup

Conversation

@MarioJGMsoft
Copy link
Copy Markdown
Contributor

@MarioJGMsoft MarioJGMsoft commented Jun 4, 2026

Description

This change is a follow up to #26912 that introduced the new internal TelemetryLoggerExt interface. Said interface can be used to replace calls to the internal ITelemetryLoggerExt

Breaking Change

This is a necessary change to enable this PR to be merged: #27476

Reviewer Guidance

The review process is outlined on this wiki page.

The change is just a naming one, no functionality was affected

Fixes: AB#74860

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (587 lines, 108 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@MarioJGMsoft MarioJGMsoft marked this pull request as ready for review June 4, 2026 18:44
@MarioJGMsoft MarioJGMsoft requested review from a team as code owners June 4, 2026 18:44
Copilot AI review requested due to automatic review settings June 4, 2026 18:44
@MarioJGMsoft MarioJGMsoft requested a review from a team as a code owner June 4, 2026 18:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 108 out of 108 changed files in this pull request and generated no comments.

@MarioJGMsoft MarioJGMsoft changed the title Migrate all internal ITelemetryLoggerExt use to TelemetryLoggerExt (refactor): Migrate all internal ITelemetryLoggerExt use to TelemetryLoggerExt Jun 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Fleet Review — Clean

No issues found across the reviewer fleet for this run.

View run

Copy link
Copy Markdown
Contributor

@Josmithr Josmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for devtools

@MarioJGMsoft MarioJGMsoft merged commit 228a839 into microsoft:main Jun 5, 2026
34 checks passed
import type {
ITelemetryLoggerExt,
TelemetryLoggerExt,
MonitoringContext,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imports are no longer sorted. Unfortunately, we don't have enforcement for that style. Most tooling I've seen will respect sort if everything already there is sorted. Otherwise, new stuff goes to the end.
Would be nice to restore sorting to changed blocks, but not high priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants