fix: make ci-readiness-check.sh compatible with bash 3.2#27465
Open
tylerbutler wants to merge 1 commit into
Open
fix: make ci-readiness-check.sh compatible with bash 3.2#27465tylerbutler wants to merge 1 commit into
tylerbutler wants to merge 1 commit into
Conversation
macOS ships bash 3.2, which lacks associative arrays (declare -A) and mapfile/readarray (bash 4+ features). Replace the associative-array package dedup with a newline-delimited string deduplicated via sort -u, and replace mapfile with a while-read loop.
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (19 lines, 1 files), I've queued these reviewers:
How this works
|
Contributor
Fleet Review — CleanNo issues found across the reviewer fleet for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ci-readiness-check.shscript failed to run on macOS because it used bash 4+ features that aren't available in the bash 3.2 that ships as the default/bin/bashon macOS.Changes
declare -Aassociative array (used to dedupe changed packages) with a newline-delimited string deduplicated viasort -u.mapfile -twith awhile readloop to populate thePACKAGESarray.Validation
Verified the script passes a syntax check (
bash -n) under the stock macOS bash: