feat: set branch in same state as it used to be#27450
Draft
MarioJGMsoft wants to merge 1 commit into
Draft
Conversation
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (606 lines, 14 files), I've queued these reviewers:
How this works
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up to #27126; it tags high volume FluidFramework telemetry events as
LogLevel.info. The goal is to let clients safely filter outinfo-tagged events without losing the signal needed to diagnose Fluid issues.Events were selected by observed telemetry volume and span both generic and performance events. For consumers today, the only observable difference is that tagged events now carry logLevel: "info" on their payload - no filtering or delivery behavior changes were made.
Reviewer Guidance
The review process is outlined on this wiki page.
LogLevel.infoparameter the formatting for various pieces of the code was updated. I highly recommend turning on thehide whitespacechanges option when reviewing this PR.Fixes: AB#52417