Add Compiler reference via cpl attr in script tag - #425
Open
Hernanm0g wants to merge 2 commits into
Open
Conversation
Contributor
|
Hey @Akryum, I was wondering if this is something we could bring into the package or if you think there is an alternative approach we can take for the loader to work (I also created #424 as pointed out by @Hernanm0g) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @Aczell described in PR #424, the lang attribute in <script> tag, causes some unwanted issues in vscode+vetur developer's experience. Aczell's solution works, so this PR is another way to solve the problem allowing a cpl attribute in script tag, for instance:
So vue-component will check for this cpl reference and, if exists, will look for a global.vue.lang.vuetify method, and will run it as a compiler.
This will help several developers, cause when you use <script lang="js">, it breaks: File autocomplete, syntax highlighting... and some weird warning pop up.