Skip to content

GCC-15#61

Closed
sbruton wants to merge 1 commit into
messense:mainfrom
sbruton:build/gcc15
Closed

GCC-15#61
sbruton wants to merge 1 commit into
messense:mainfrom
sbruton:build/gcc15

Conversation

@sbruton
Copy link
Copy Markdown

@sbruton sbruton commented Dec 5, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 5, 2025 16:48
@sbruton sbruton closed this Dec 5, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the CI build workflow by commenting out 9 out of 12 build targets, leaving only 3 ARM-based targets active (armv7-unknown-linux-gnueabihf, arm-unknown-linux-gnueabi, and arm-unknown-linux-gnueabihf). The title "GCC-15" suggests this may be related to testing GCC-15 compatibility, though the current toolchain configurations still reference GCC 13.3.0.

Key Changes:

  • Commented out x86_64 and aarch64 Linux targets (both gnu and musl variants)
  • Commented out i686 Linux targets (both gnu and musl variants)
  • Commented out armv7-unknown-linux-musleabihf, arm-unknown-linux-musleabihf, and mipsel-unknown-linux-gnu targets
  • Reduced active build matrix from 12 to 3 targets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +31 to +42
# - x86_64-unknown-linux-gnu
# - x86_64-unknown-linux-musl
# - i686-unknown-linux-gnu
# - i686-unknown-linux-musl
# - aarch64-unknown-linux-gnu
# - aarch64-unknown-linux-musl
- armv7-unknown-linux-gnueabihf
- armv7-unknown-linux-musleabihf
# - armv7-unknown-linux-musleabihf
- arm-unknown-linux-gnueabi
- arm-unknown-linux-gnueabihf
- arm-unknown-linux-musleabihf
- mipsel-unknown-linux-gnu
# - arm-unknown-linux-musleabihf
# - mipsel-unknown-linux-gnu
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the build targets have been commented out, leaving only 3 ARM targets active. This significantly reduces the build matrix from 12 to 3 targets.

If this is intended as a temporary change for testing GCC-15 compatibility, consider:

  1. Adding a comment in the workflow explaining this is temporary
  2. Creating a separate workflow or branch for testing rather than modifying the main build workflow
  3. Ensuring all targets are re-enabled before merging to production

If this is permanent, it would be a breaking change that removes support for popular architectures like x86_64 and aarch64.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants