Program name fixies#2747
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames to programs:
anvi-script-gen-function-matrix-across-genomesis nowanvi-gen-function-matrix, andanvi-script-gen-hmm-hits-matrix-across-genomesis nowanvi-gen-hmm-hits-matrix.Following #2746, I realized that
anvi-script-gen-function-matrix-across-genomesis no longer specific to 'genomes'. Which has never been the case actually, and I am not sure why the original script name had that level of specificity, but now it certainly not specific since PPCN normalization is only relevant for metagenomic assemblies.While at it, I also fixed
anvi-script-gen-hmm-hits-matrix-across-genomessince the same applies.I think we should add the same flag to
anvi-gen-hmm-hits-matrix(which will require PPCN reporting to be its own class elsewhere), but it can wait.