Skip to content

test(inventory): port inventory management tests to integration:ng - #2077

Open
p-targowicz wants to merge 1 commit into
ng-rewrite-05-artifactsfrom
ng-rewrite-06-inventory
Open

test(inventory): port inventory management tests to integration:ng#2077
p-targowicz wants to merge 1 commit into
ng-rewrite-05-artifactsfrom
ng-rewrite-06-inventory

Conversation

@p-targowicz

@p-targowicz p-targowicz commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Part of the suite-by-suite python-to-Go port (see #2079). Ports
test_inventory.py: device listing and filtering including numeric
attributes, and device patch attributes. The python tests keep running
in parallel. Builds on #2079.

@p-targowicz
p-targowicz changed the base branch from rewrite-backend-integration-tests-ng to ng-rewrite-01-foundation July 17, 2026 10:20
@p-targowicz
p-targowicz force-pushed the ng-rewrite-01-foundation branch from d19a365 to 0754f85 Compare July 17, 2026 10:34
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from 13bda4c to b330e55 Compare July 17, 2026 10:34
@p-targowicz
p-targowicz changed the base branch from ng-rewrite-01-foundation to ng-rewrite-05-artifacts July 17, 2026 10:35
@p-targowicz
p-targowicz marked this pull request as ready for review July 17, 2026 11:09
@p-targowicz
p-targowicz requested a review from a team as a code owner July 17, 2026 11:09
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from 003279b to c68b4e7 Compare July 20, 2026 09:23
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from b330e55 to e5eb197 Compare July 20, 2026 09:23
@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from c68b4e7 to 9c5a989 Compare July 20, 2026 10:10
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from e5eb197 to eab1469 Compare July 20, 2026 10:10
@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from 9c5a989 to 5bd0b33 Compare July 28, 2026 07:13
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from eab1469 to 5a4794a Compare July 28, 2026 07:13
@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from 5bd0b33 to 50fe9f1 Compare July 28, 2026 09:19
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from 5a4794a to 23e461d Compare July 28, 2026 09:19
@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from 50fe9f1 to e9c52f7 Compare July 28, 2026 09:26
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from 23e461d to 5ab76dc Compare July 28, 2026 09:26
@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from e9c52f7 to 30fa17c Compare July 29, 2026 00:03
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from 5ab76dc to 89d7c70 Compare July 29, 2026 00:03
@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from 30fa17c to c9ab26f Compare July 29, 2026 07:48
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from 89d7c70 to 4b982c8 Compare July 29, 2026 07:48
@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from c9ab26f to f1e3b31 Compare July 29, 2026 13:03
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from 4b982c8 to caa7692 Compare July 29, 2026 13:03
@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from f1e3b31 to 5d258ba Compare July 30, 2026 12:36
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch 2 times, most recently from 3d91b2c to 8e676f2 Compare July 30, 2026 13:00
@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from 5d258ba to 4185584 Compare August 3, 2026 10:14
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from 8e676f2 to 0a98bc4 Compare August 3, 2026 10:15

@bahaa-ghazal bahaa-ghazal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just some comments

Comment thread backend/tests/runner/tests/opensource/inventory_management_v1_test.go Outdated
@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from 4185584 to f7f93ba Compare August 3, 2026 11:51
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from 0a98bc4 to 9de5aa3 Compare August 3, 2026 11:52
Device listing and filtering including numeric attributes, and device
patch attributes, ported from test_inventory.py, which keeps running
in parallel.

Signed-off-by: Patryk Targowicz <patryk.targowicz@northern.tech>
@p-targowicz
p-targowicz force-pushed the ng-rewrite-05-artifacts branch from f7f93ba to 68d4971 Compare August 3, 2026 11:59
@p-targowicz
p-targowicz force-pushed the ng-rewrite-06-inventory branch from 9de5aa3 to 36c91fe Compare August 3, 2026 11:59

@bahaa-ghazal bahaa-ghazal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants